Tk Toolkit / Read-Only Bugs / #2865 Fix buffer overflow w/ GCC 4.5 and -D_FORTIFY_SOURCE=2

#2865 Fix buffer overflow w/ GCC 4.5 and -D_FORTIFY_SOURCE=2

Milestone: obsolete: 8.6b1.1

Status: closed-fixed

Owner: Jan Nijtmans

Labels: 99. Other (73)

Priority: 5

Updated: 2011-01-25

Created: 2010-12-06

Creator: Jan Nijtmans

Private: No

Same as [Tcl patch #3048354], but it turns out that Tk uses the same pattern as well.

Discussion

Jan Nijtmans - 2010-12-06

assigned_to: nobody --> nijtmans
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2010-12-06

proposed fix

3129527.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2010-12-06

Fixed on HEAD

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2010-12-06

status: open --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2010-12-06

proposed fix (same, but for Tk 8.5)

3129527_85.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2010-12-06

proposed fix (same, but for Tk 8.4)

3129527_84.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Joe English - 2011-01-24

Looks like you missed a spot -- see #3164879 for details.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2011-01-25

Good catch! Thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2011-01-25

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Nijtmans - 2011-01-25

Backported the srccpy -> memcpy change to 8.5 and 8.4, not the structure
change in order to prevent repeating anything like #3164879.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: