Menu

#2517 tests substantively changed. Why?

obsolete: 8.6a2
open
ania
5
2008-10-09
2008-10-09
Don Porter
No

The 2008-07-22 commit to entry.test has
the simple log message "Update to tcltest2".

But that's not all that happened. Several
tests were re-named/re-numbered, which is
bad, but I believe I can correct that.

Some other tests were changed in substantive
ways without any comment about why. As one
example, test entry-2.3 was:

test entry-2.3 {Tk_EntryCmd procedure} {
catch {destroy .e}
entry .e
list [winfo exists .e] [winfo class .e] [info commands .e]
} {1 Entry .e}

And now it is:

test entry-2.3 {Tk_EntryCmd procedure} -body {
entry .e
pack .e
update
list [winfo exists .e] [winfo class .e] [info commands .e]
} -cleanup {
destroy .e
} -result {1 Entry .e}

I like the improved formatting and use
of features of tcltest 2. But what are
those additions of [pack] and [update]
doing in there? Adding those changes
the nature of what is being tested. This
is only one simple example.

I want to change these back to remain
consistent with what's been tested in
the past, but I do not know whether making
such changes will undo some bug fix which
is behind making the change in the first
place. This is why good commit comments
are so important. It's not only good
to have a record of what changed, but also
why it was changed.

Discussion

MongoDB Logo MongoDB