Menu

#986 GetCVar("realmName") overused in Titan Panel plugins

Resolved
nobody
None
Defect-WoWIn
2015-02-19
2014-05-24
Anonymous
No

Originally created by: Honor...@gmail.com
Originally owned by: Honor...@gmail.com

Originally Posted by AnrDaemon on WoWInterface:
Curious enough, TitanGold uses both GetCVar("realmName") and GetRealmName() calls.
But overall, Titan plugins calling GetRealmName() in way too many places. Need heavy overhaul.
No any other plugin, that deal with realm name, calling GetRealmName() more than once per session.
I checked on this and found the following in our package:

TitanPanel : 1 call (all local)
TitanUtils : 1 call (all local)
TitanClock : 3 calls (all local)
TitanGold : 7 calls (6 local)

As TitanGold was once TitanGoldTracker and developed independently, I'm not sure why it has so many references but I will be checking on it. Same with TitanClock which is actually entirely our fault as we've "owned" that one for a great many years.

Related

Wiki: Titan_Panel_Version_History

Discussion

  • Anonymous

    Anonymous - 2014-11-11

    Originally posted by: Honor...@gmail.com

    (No comment was entered for this change.)

    Labels: Type-Defect-WoWInt

     
  • Anonymous

    Anonymous - 2014-11-11

    Originally posted by: Honor...@gmail.com

    (No comment was entered for this change.)

    Labels: -Type-Defect-WoWInt Type-Defect-WoWIn

     
  • Anonymous

    Anonymous - 2015-02-19

    Originally posted by: Honor...@gmail.com

    With the latest release, I've finally completed this one.

    Status: Resolved

     

Log in to post a comment.