#896 TitanRepair: Still a problem with repair and guildbank on all my Guild Masters

[Anonymous]

Originally created by: yngve.w...@gmail.com
Originally owned by: Honor...@gmail.com

What version of Titan Panel are you using and on what operating system?
5.1.17.50200
Date: 24.03.2013 08:48:49
Type: Release
Windows 7

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
Expected to be able to toggle use of guild bank like the rest of mine chars. But on all my GM's this gives an error.

Please attach a screenshot if you believe that will assist.
Please provide any additional information below that you feel is relevant.
Error message:
Date: 2013-03-30 16:22:42
ID: 1
Error occured in: Global
Count: 1
Message: integer overflow attempting to store 1.844674407371e+015
Debug:
   [C]: format()
   TitanRepair\TitanRepair.lua:1154: TitanPanelRepair_GetTextGSC()
   TitanRepair\TitanRepair.lua:1324: initFunction()
   ..\FrameXML\UIDropDownMenu.lua:69: UIDropDownMenu_Initialize()
   ..\FrameXML\UIDropDownMenu.lua:864: ToggleDropDownMenu()
   [string "*:OnEnter"]:5:
      [string "*:OnEnter"]:1
Locals:
(*temporary) = "|cff%s%d"
(*temporary) = "ffd100"
(*temporary) = 1.844674407371e+015

AddOns:
  Swatter, v4.2.0 (<%codename%>)
  WowheadLooter, v50008
  NPCScan, v5.0.0.5
  NPCScanOverlay, v5.0.0.3
  Accountant, v4.12.50200
  AckisRecipeList, v2.4.6
  ACP, v3.4.2
  Altoholic, v5.2.001
  ArkInventory, v30327
  ArkInventoryRules, v
  Atlas, v1.24.00
  AtlasBattlegrounds, v1.24.00
  AtlasBurningCrusade, v1.24.00
  AtlasCataclysm, v1.24.00
  AtlasClassicWoW, v1.24.00
  AtlasOutdoorRaids, v1.24.00
  AtlasScenarios, v1.24.00
  AtlasTransportation, v1.24.00
  AtlasWorldEvents, v3.01
  AtlasWrathoftheLichKing, v1.24.00
  AtlasLoot, vv7.05.02
  AtlasLootCataclysm, vv7.05.02
  AtlasLootClassicWoW, vv7.05.02
  AtlasLootLoader, vv7.05.02
  AtlasLootMistsofPandaria, vv7.05.02
  AtlasMajorCitiesEnhanced, vv1.00
  AtlasQuest, v4.8.3
  AucAdvanced, v5.15.5383 (LikeableLyrebird)
  AucFilterBasic, v5.15.5383 (LikeableLyrebird)
  AucFilterOutlier, v5.15.5383.5381(5.15/embedded)
  AucMatchUndercut, v5.15.5383.5381(5.15/embedded)
  AucScanData, v5.15.5383 (LikeableLyrebird)
  AucStatHistogram, v5.15.5383 (LikeableLyrebird)
  AucStatiLevel, v5.15.5383 (LikeableLyrebird)
  AucStatPurchased, v5.15.5383 (LikeableLyrebird)
  AucStatSales, v5.15.5383.5381(5.15/embedded)
  AucStatSimple, v5.15.5383 (LikeableLyrebird)
  AucStatStdDev, v5.15.5383 (LikeableLyrebird)
  AucStatWOWEcon, v5.15.5383.5323(5.15/embedded)
  AucUtilAHWindowControl, v5.15.5383.5381(5.15/embedded)
  AucUtilAppraiser, v5.15.5383.5381(5.15/embedded)
  AucUtilAskPrice, v5.15.5383.5381(5.15/embedded)
  AucUtilAutoMagic, v5.15.5383.5381(5.15/embedded)
  AucUtilCompactUI, v5.15.5383.5381(5.15/embedded)
  AucUtilEasyBuyout, v5.15.5383.5381(5.15/embedded)
  AucUtilFixAH, v5.15.5383 (LikeableLyrebird)
  AucUtilItemSuggest, v5.15.5383.5381(5.15/embedded)
  AucUtilPriceLevel, v5.15.5383.5381(5.15/embedded)
  AucUtilScanButton, v5.15.5383.5320(5.15/embedded)
  AucUtilScanFinish, v5.15.5383.5381(5.15/embedded)
  AucUtilScanProgress, v5.15.5383.4979(5.15/embedded)
  AucUtilScanStart, v5.15.5383.5381(5.15/embedded)
  AucUtilSearchUI, v5.15.5383.5381(5.15/embedded)
  AucUtilSimpleAuction, v5.15.5383.5381(5.15/embedded)
  AucUtilVendMarkup, v5.15.5383.4828(5.15/embedded)
  AutoProfitX, vr83
  AutoText, vv5.1-release
  Babylonian, v5.1.DEV.332(/embedded)
  BadBoy, v12.000
  BadBoyCCleaner, v3.64
  BadBoyLevels, v2.95
  Bartender4, v4.5.9
  BeanCounter, v5.15.5383 (LikeableLyrebird)
  BrokerLocation, v1.8
  BrokerProfessionsMenu, v
  BrokerRecountFu, v1.17
  BrokerRestFu, v50200-1
  ButtonFacade, v5.2.391
  ButtonFacadeDemigodRound, v3.0.3
  ButtonFacadeDemigodSquare, v3.0.3
  ButtonForge, v0.9.27
  Configator, v5.1.DEV.344(/embedded)
  DataStore, v5.2.001
  DataStoreAchievements, v5.2.001
  DataStoreAgenda, v5.2.001
  DataStoreAuctions, v5.2.001
  DataStoreCharacters, v5.2.001
  DataStoreContainers, v5.2.001
  DataStoreCrafts, v5.2.001
  DataStoreCurrencies, v5.2.001
  DataStoreInventory, v5.2.001
  DataStoreMails, v5.2.001
  DataStorePets, v5.2.001
  DataStoreQuests, v5.2.001
  DataStoreReputations, v5.2.001
  DataStoreSpells, v5.2.001
  DataStoreStats, v5.2.001
  DataStoreTalents, v5.2.001
  DBMCore, v
  DBMLDB, v
  DebugLib, v5.1.DEV.337(/embedded)
  DungeonHelper, vv2.3.4
  Enchantrix, v5.15.5383 (LikeableLyrebird)
  EnchantrixBarker, v5.15.5383 (LikeableLyrebird)
  EpicMusicPlayer, vr58
  EpicMusicPlayerBroker, v58
  EpicMusicPlayerDancer, v58
  EpicMusicPlayerGameMusic, v58
  Factionizer, v05.02.00 13.03.21
  FlightMap, v5.2.0
  Gatherer, v4.2.0
  GathererHUD, v4.2.0
  Glamour, v1.4.3
  GuildLaunchProfiler, v01.05.00
  GuildRosterButtons, v3.3
  HealBot, v5.2.0.2
  HealBotTips, v5.2.0.2
  iMoney, v2.0.8
  Informant, v5.15.5383 (LikeableLyrebird)
  InspectEquip, v2.0.4
  LibExtraTip, v5.12.DEV.342(/embedded)
  LostTreasures, v3.05
  MacroBank, v1.11
  MacroToolkit, vv5.2.0.1
  MacroToolkitMacroBox, vv5.2.0.0
  Masque, v5.2.391
  MikScrollingBattleText, v5.7.127
  MinimalArchaeology, v5.2.0 (07.03.12)
  MobInfo2, v5.0.4.0
  MountHelper, vrelease 13
  MoveAnything, v13.5.1
  NotesUNeed, v6.82.50001
  Omen, v3.1.8
  OmniCC, v5.2.2
  oRA3, v
  Overachiever, v0.71
  OverachieverTrade, v0.71
  Panda, v5.2.0.46
  Pawn, v1.8.4
  PetBattleTeams, v3.1.3
  PetJournalEnhanced, v2.6.6
  PetTracker, v
  PetTrackerAlerts, v
  PetTrackerBroker, v
  PetTrackerJournal, v
  PetTrackerSwitcher, v
  PokemonTrainer, v1.1.5
  Postal, v3.5.1
  Prat30, v3.5.5     
  Prat30Libraries, v
  ProspectBar, vv201210250038
  Quartz, v3.1.2
  QuestCompletist, v100.0
  QuestGuru, v2.2.13-50001
  QuestGuruTracker, v1.5.14-50001
  RaidMobMarker, v5.0.4
  RangeDisplay, vv4.2.0
  Rarity, v1.0
  RarityOptions, v
  RatingBuster, vr396
  Recount, v
  recruitmentenhancement, v50100-0.7-release
  SexyMap, v2.4.5
  Skillet, v
  SlideBar, v4.2.0 (<%codename%>)
  SmartBuff, v5.1d
  SmartDebuff, v5.1b
  SocialState, v5.0-Release1
  Stubby, v5.15.5383 (LikeableLyrebird)
  TipHelper, v5.12.DEV.343(/embedded)
  Titan, v5.1.17.50200
  TitanHealBot, v5.2.0.0
  TitanLootType, v5.1.17.50200
  TitanPerformance, v5.1.17.50200
  TitanRepair, v5.1.17.50200
  TitanReputation, v3.7.7
  TitanRoll, v
  TitanVolume, v5.1.17.50200
  TitanXP, v5.1.17.50200
  TomTom, vv50200-1.0.2
  Warden, v3.3.8
  WIM, v3.6.6
  XPerl, v3.6.30
  XPerlArcaneBar, v
  XPerlParty, v
  XPerlPartyPet, v
  XPerlPlayer, v
  XPerlPlayerBuffs, v
  XPerlPlayerPet, v
  XPerlRaidAdmin, v
  XPerlRaidFrames, v
  XPerlRaidHelper, v
  XPerlRaidMonitor, v
  XPerlRaidPets, v
  XPerlTarget, v
  XPerlTargetTarget, v
  BlizRuntimeLib_enUS v5.2.0.50200 <eu>
  (ck=1577)

[Anonymous]

Originally posted by: Honor...@gmail.com

Yeah, that's what I was afraid of.  I know exactly what is happening.  I'll take care of this on Sunday and will send out an update afterwards.  Blizzard tells people to not use Guild Masters when playing with the guild bank routines as most characters are not Guild Masters.  My fault for not testing this before release.  TitanPanelRepair_GetTextGSC() does not like the negative 1 that Guild Masters are set to.  Should be an easy fix for me once I get some sleep.

Owner: Honor...@gmail.com
Status: Accepted

[Anonymous]

Originally posted by: Honor...@gmail.com

Resolved in 5.1.18.

Status: Resolved

[Anonymous]

Originally posted by: kaneg...@gmail.com

This is happening again in 6.0.2 with 5.3.0.60000 installed. Looking at the code, I was able to fix it by changing (lines 1282-1284:

if IsGuildLeader() ~= 1 then
    withdrawGB = TitanPanelRepair_GetTextGSC(withdrawGBCP);
end

to

if IsGuildLeader() == 1 then
    withdrawGB = TitanPanelRepair_GetTextGSC(withdrawGBCP);
end

( ~= changed to == )

For reference, the error is exactly as posted above, but the code line numbers are 1111/1283 in TitanRepair and 69/898 in the menu xml.

[Anonymous]

Originally posted by: kaneg...@gmail.com

Disregard, I found the real issue, and it's related to several other issues I've discovered across many addons.

Nearly all of WoW's API calls now follow Lua 5.2's "documented" behavior for boolean settings and returns and will no longer work or return 1s and 0s. Instead of using IsGuildLeader() ~= 1, use IsGuildLeader() ~= true.

[Anonymous]

Originally posted by: kaneg...@gmail.com

Sorry for comment spam. Wish I could edit comments. Anyways, it would be a good idea to comb every piece of code for any binary usage in API calls and replace them with false or true appropriately.

[Anonymous]

Originally posted by: Honor...@gmail.com

No problem.  We missed the window for the update today but I'll make sure it gets in the next one.  If you find any more boolean errors, please let me know.  I just love it when Blizzard makes changes like this.  Sort of like the time they reversed the logic on showing the GM ticket frame right before a major release.  Did it right before release and it was never in the PTR.  Titan Panel crashed their helpdesk system.  Generated over a million tickets in a single 12 hour period.  People clicked on the visible frame, <boom>, instant ticket generation.  Blizzard actually called my house line on that one.  Go figure.  I think I still have a screenshot of the yellow alert text on login for people using Titan Panel that Blizzard added.  I laughed.

Status: Accepted

[Anonymous]

Originally posted by: Honor...@gmail.com

(No comment was entered for this change.)

Summary: TitanRepair: Still a problem with repair and guildbank on all my Guild Masters

[Anonymous]

Originally posted by: Honor...@gmail.com

(No comment was entered for this change.)

Status: Testing

[Anonymous]

Originally posted by: Honor...@gmail.com

(No comment was entered for this change.)

Status: Resolved