#878 Enhancement: TitanXP Large Number Comma Seperators

[Anonymous]

Originally created by: esiemiat...@gmail.com

This isn't really a bug, but at higher levels the XP numbers displayed in TitanXP become difficult to read without comma seperators. For example instead of 22550678, it would be easier to read 22,550,678.

I modified my local copy of TitanXP to accomplish this and have not found any issues with the changes over the past couple of weeks. The changes were small and only involving a few lines of code in TitanXP.lua and changing %d to %s in a 4 localization table entries. I even used Blizzard's _G.LARGE_NUMBER_SEPERATOR constant so this change can support other languages.

I have attached a ZIP file containing my changes. Feel free to use them if you want to.

[Anonymous]

Originally posted by: Honor...@gmail.com

That's a great idea.  I'll see if I can get this into the next update.

Status: Accepted

[Anonymous]

Originally posted by: Honor...@gmail.com

(No comment was entered for this change.)

Labels: Type-Enhancement

[Anonymous]

Originally posted by: Honor...@gmail.com

This is moving into testing mode.

Status: Testing

[Anonymous]

Originally posted by: esiemiat...@gmail.com

Thank you. Very cool to see this feature implemented. However, I noticed there were a few numbers that were skipped. I have attached a ZIP with the files I updated to get them all. I have also attached a comparison report outlining the changes made to TitanXP.lua.

To get these chages to work these 2 entries in the localization files need to be changed as well. Basically, the '%d' gets changed to a '%s'.

L["TITAN_XP_KILLS_LABEL"] = "Kills To Level (at %d XP gained last): ";
L["TITAN_XP_XPGAINS_LABEL"] = "XP Gains To Level (at %d XP gained last): ";

[Anonymous]

Originally posted by: Honor...@gmail.com

@Esiemiatkaska: That was awesome.  A lot of these were already put in but a few were missed during my latest update so I have them all in now.  I put TITAN_XP_FORMAT back in but made it a string instead of an integer.  The 5.1.13 release will be going out on Saturday evening with these changes.

Are you interested in joining the team and helping out with the coding duties?

[Anonymous]

Originally posted by: esiemiat...@gmail.com

Yes, I would like to join the team. Whatever I can do to help.

[Anonymous]

Originally posted by: Honor...@gmail.com

Hello Eric, I'll get you added to the team.  Please make an account over on WoWInterface as that is where we host our SVN depository.

Also, this issue is going into final testing with the 5.1.13.50100 release tonight.  If there are any problems, please let me know.  I will be closing this issue on Monday if there are no more problems.

Status: Fixed

[Anonymous]

Originally posted by: Honor...@gmail.com

This should have been resolved in 5.1.13.50100.

Status: Resolved

[Anonymous]

Originally posted by: esiemiat...@gmail.com

Sorry for the late response. I missed your first message about creating an
account.

Anyway, I tested these changes on both the live and 5.2 PTR servers and
they look good. Thanks for getting them done so fast and the team invite.

As asked I created an account on WoWInterface. The username is 'esiemiat'.
Let me know if you need anything else from me.