#803 TitanRepair - Use Guild Bank Funds fails

[Anonymous]

Originally created by: jmoack...@gmail.com

- What version of Titan Panel are you using and on what operating system?

5.0.12.40300
Windows 7 Professional

- What steps will reproduce the problem?

Visit a repair npc with autorepair enabled (and damaged gear, guild bank on) for the first time in a session.

- What is the expected output? What do you see instead?

Expected output: Successful repair
Actual output: "Titan Repair:Guild Bank can't afford the repair cost, or you can't withdraw that much."

- Please provide any additional information below that you feel is relevant.

Regardless of what that error message says, I have never reached my withdraw limit nor has our guild bank ever been empty since I joined it a year and a half ago. This error, as stated above, only happens on the first visit to a repair npc during a session. Fixing this requires me to manually click the "repair all" button in the npc window. Subsequent autorepair attempts work fine.

I would also like to mention that prior to my first attempt in a session, the tooltip states the correct guild bank amount, but my limit is 0. Visiting the guild bank seems to not "refresh" this. So far, the only fix is manually using the repair all button to force a guild bank repair, and thereafter in the current session all autorepairs work. /reloading seems to not have an affect (either fixing the problem or reproducing it after the manual repair) but logging out and/or exiting the client, then logging back in reproduces the issue.

[Anonymous]

Originally posted by: Honor...@gmail.com

This appears to be a problem within the BlizzardRepairUI.  There isn't much we can do except hope it gets resolved in a future patch.  We'll test with the new 5.0.4 build.

Status: Helping

[Anonymous]

Originally posted by: Honor...@gmail.com

This is still happening with WoW 5.0.5.  There wasn't a fix released by Blizzard.  I'll look at a few other addons and see if someone else has developed a work-around.

Status: Pending

[Anonymous]

Originally posted by: zecan...@gmail.com

Would a reasonable workaround be to just try repairing anyway and checking the result? The guild repair button is available when you visit a merchant with the ability to repair and you have equipment that needs repairing. This sounds a little dirty, but in my opinion it's better than making players remember to repair manually even though they've enabled the option to repair automatically.

[Anonymous]

Originally posted by: kaneg...@gmail.com

You mean have the addon do a normal repair? I think that's too much of a work-around, especially in cases where your first repair of a session might be the biggest. Also, if you are constantly aware of this work-around, having to slightly damage yourself just so the autorepair can work is much more effort than simply clicking the repair once. If you meant try to perform a repair, the addon already does that and the result is the reason for this bug in the first place.

[Anonymous]

Originally posted by: zecan...@gmail.com

No yeah I meant have the add-on automatically try to do a guild repair even if the available funds are "insufficient".

As the player, after I click the guild repair button once, the add-on works just fine for the remainder of the session, as described in the bug report. So my suggestion was to have Titan Repair automatically attempt that step. So it seems reasonable to me that if the add-on succeeded in auto-repairing using guild funds, then everything would work on its own after that.

I'm not sure why you think the player would have to be constantly aware of things that the add-on would try to do on its own to get past the initial weird state, but I might not have expressed myself correctly.

[Anonymous]

Originally posted by: kaneg...@gmail.com

Now I understand you.

If I interpreted HonorGoG's responses correctly, it's not the addon's code that is the issue, it's Blizzard's RepairUI reporting incorrectly. It might be that it's reporting 0 for guild funds or just simply failing in a strange way only a manual click can fix.

[Anonymous]

Originally posted by: zecan...@gmail.com

Yes, hence my suggestion.

[Anonymous]

Originally posted by: Honor...@gmail.com

I'm hoping that this will be repairable with the 5.2 patch.  It's a simple API call but unfortunately, Blizzard removed the function that worked in the past.  The new routine is causing this problem.  I'm going to leave this open until after the 5.2 release.  If Blizzard doesn't fix it, we'll have to close this issue until Blizzard resolves the problem.  When that happens, we'll update the code.

So, if the 5.2 does not resolve this, I will close the issue.  If it does, I will fix the problem and close this issue.

Summary: 5.2: TitanRepair - Use Guild Bank Funds fails
Labels: Priority-Closing

[Anonymous]

Originally posted by: Honor...@gmail.com

The Blizzard routine GetGuildBankMoney() is broken.  It requires the guild bank frame to be open to return anything other than a zero value.  I've developed a work around and I'm testing it tonight.

Summary: TitanRepair - Use Guild Bank Funds fails
Labels: -Priority-Closing
Status: Testing

[Anonymous]

Originally posted by: Honor...@gmail.com

(No comment was entered for this change.)

Status: Resolved