tipc-discussion

[Tipc-discussion] RE: Another tipc observation

[Jon M. (QB/EMC) <jon...@er...>]

Certainly not. I am surprised that it works at all,
given that the management code is not tested at all
yet. Feel free to correct it.

Thanks /Jon

-----Original Message-----
From: Mark Haverkamp
To: Jon Maloy (QB/EMC)
Cc: tipc
Sent: 09.04.2004 16:04
Subject: Another tipc observation

While running some more tests, I noticed that the TIPC_GET_NODES
management command doesn't return the node addresses in network order
like the old TIPC_GET_PROCESSORS command does.  Just curious if it is
supposed to be that way.

Mark.
-- 
Mark Haverkamp <ma...@os...>

Re: [Tipc-discussion] RE: Another tipc observation

[Mark H. <ma...@os...>]

On Sat, 2004-04-10 at 11:06, Jon Maloy (QB/EMC) wrote:
> Certainly not. I am surprised that it works at all,
> given that the management code is not tested at all
> yet. Feel free to correct it.
> 
> Thanks /Jon
> 
OK, here is a fix that works.  I made the change in the node_get_nodes
function.  It is only called by the manager.  If you would rather, I
could fix it in mng_cmd_event but that would require casting the data
buffer to a tipc_node_info and doing the htonl there.

Mark.

--- /home/markh/views/tipc/cvs/source/unstable/net/tipc/node.c	2004-03-30 07:11:39.000000000 -0800
+++ node.c	2004-04-14 09:54:30.000000000 -0700
@@ -613,8 +613,8 @@
 	for(n = nodes;n;n = n->next) {
 		if (!in_scope(scope,n->addr))
 			continue;
-                list[cnt].addr = n->addr;
-                list[cnt].up = node_is_up(n);
+                list[cnt].addr = htonl(n->addr);
+                list[cnt].up = htonl(node_is_up(n));
                 cnt++;
 	};
 	return (cnt * sizeof(struct tipc_node_info));


-- 
Mark Haverkamp <ma...@os...>

Re: [Tipc-discussion] RE: Another tipc observation

[Jon M. <jon...@er...>]

The solution is fine. Just check it in.

/jon

Mark Haverkamp wrote:


On Sat, 2004-04-10 at 11:06, Jon Maloy (QB/EMC) wrote:

  

Certainly not. I am surprised that it works at all,

given that the management code is not tested at all

yet. Feel free to correct it.



Thanks /Jon



    

OK, here is a fix that works.  I made the change in the node_get_nodes

function.  It is only called by the manager.  If you would rather, I

could fix it in mng_cmd_event but that would require casting the data

buffer to a tipc_node_info and doing the htonl there.



Mark.



--- /home/markh/views/tipc/cvs/source/unstable/net/tipc/node.c
2004-03-30 07:11:39.000000000 -0800

+++ node.c	2004-04-14 09:54:30.000000000 -0700

@@ -613,8 +613,8 @@

 	for(n = nodes;n;n = n->next) {

 		if (!in_scope(scope,n->addr))

 			continue;

-                list[cnt].addr = n->addr;

-                list[cnt].up = node_is_up(n);

+                list[cnt].addr = htonl(n->addr);

+                list[cnt].up = htonl(node_is_up(n));

                 cnt++;

 	};

 	return (cnt * sizeof(struct tipc_node_info));





  

Re: [Tipc-discussion] RE: Another tipc observation

[Jon M. <jon...@er...>]

Hi again.
I just checked it in myself, along with some other corrections.
I also added a corresonding file release, tipc-1.3.09

/jon

Mark Haverkamp wrote:


On Sat, 2004-04-10 at 11:06, Jon Maloy (QB/EMC) wrote:

  

Certainly not. I am surprised that it works at all,

given that the management code is not tested at all

yet. Feel free to correct it.



Thanks /Jon



    

OK, here is a fix that works.  I made the change in the node_get_nodes

function.  It is only called by the manager.  If you would rather, I

could fix it in mng_cmd_event but that would require casting the data

buffer to a tipc_node_info and doing the htonl there.



Mark.



--- /home/markh/views/tipc/cvs/source/unstable/net/tipc/node.c
2004-03-30 07:11:39.000000000 -0800

+++ node.c	2004-04-14 09:54:30.000000000 -0700

@@ -613,8 +613,8 @@

 	for(n = nodes;n;n = n->next) {

 		if (!in_scope(scope,n->addr))

 			continue;

-                list[cnt].addr = n->addr;

-                list[cnt].up = node_is_up(n);

+                list[cnt].addr = htonl(n->addr);

+                list[cnt].up = htonl(node_is_up(n));

                 cnt++;

 	};

 	return (cnt * sizeof(struct tipc_node_info));