[tipc-discussion] Re: How to deal with unused TIPC routines?

[Jon M. <jon...@er...>]

NO,NO
These functions are used,  they belong to the driver user API, and makes it
possible to tunnel sk_buffs, e.g. containing IP-messages, straight trough
TIPC without copying, i.e. just prepending them with a TIPC header.
The same goes for the extra **void parameters in the callback functions, 
which
makes it possible for the receiver to grab the sk_buff from TIPC and pass
it on, instead of having to copy the contents.
We have at least two applications within Ericsson making use of these.

/jon

Stephens, Allan wrote:

> Hi all:
>
> Now that the TIPC facelift has started, I'm starting to encounter 
> pieces of code that are not currently used.  For example, the 
> following routines in port.c all appear to be unused: tipc_send_buf(), 
> tipc_forward_buf2port(), tipc_send_buf2port(), 
> tipc_forward_buf2name(), and tipc_send_buf2name().  I suspect that 
> this code probably deals with multi-cluster TIPC, which is not 
> currently supported.
>
> How should we deal with code of this sort?  I can see 3 options:
> 1) delete the code (at least for now)
> 2) surround by conditional compilation directive -- eg. #ifdef 
> TIPC_FUTURE or #ifdef TIPC_UNUSED
> 3) leave as is
>
> Unless I hear objections, I'll go ahead with option 1.  (I'm sure the 
> Linux community wouldn't approve of option 3, and I have my doubts 
> that they'd be wild about option 2.)
>
> Regards,
> Al
>