Re: [Tipc-discussion] REPLICA_NODES set to 1

[Jon M. <jon...@er...>]

I can not find anything about this in the kernel style guides
I have looked through, but I a quick search in google gave me=20
this URL:=20
http://linux.derkeiler.com/Mailing-Lists/Kernel/2003-10/5316.html
<http://linux.derkeiler.com/Mailing-Lists/Kernel/2003-10/5316.html>=20

It should be fixed.

/jon

Mark Haverkamp wrote:


On Thu, 2004-06-10 at 18:43, Ling, Xiaofeng wrote:

 =20

-----Original Message-----

From: Mark Haverkamp [ mailto:ma...@os... <mailto:ma...@os...> ]=20

Sent: 2004=E5=B9=B46=E6=9C=8811=E6=97=A5 0:17

To: Ling, Xiaofeng

Cc: tipc

Subject: RE: [Tipc-discussion] REPLICA_NODES set to 1



On Thu, 2004-06-10 at 08:36, Mark Haverkamp wrote:

     =20

On Thu, 2004-06-10 at 02:41, Ling, Xiaofeng wrote:

       =20

Yes, that's problem.The broadcast packet is not received by sender,

maybe we need to copy one to sender self.

how about this patch?  (The reture value still need to be resolved)

         =20

That seemed to work OK.

       =20

One small thing.  The patch declares the struct sk_buff below the start

of the code block.  This isn't standard C.

     =20

But It's in C99 standard, isn't it? :)

   =20



Sorry, I didn't realize that. I don't think that I've seen kernel files

declare variables other than at the start of a code block though.  Maybe

its a kernel coding style thing.





Mark.



 =20