Re: [Tipc-discussion] name_table.c printk

[Jon M. <jon...@er...>]

Not only there. They should be replaced everywhere with
the appropriate level dbg(),warn(),info() etc.  I see there
is quite a few of them left in i bcast code.

/jon

Mark Haverkamp wrote:

>I'd like to propose changing the printk calls in name_table.c to dbg
>calls.  This eliminates lots of chatter on my console.
>
>Mark.
>
>cvs diff -u name_table.c
>Index: name_table.c
>===================================================================
>RCS file: /cvsroot/tipc/source/unstable/net/tipc/name_table.c,v
>retrieving revision 1.18
>diff -u -r1.18 name_table.c
>--- name_table.c	10 May 2004 21:07:57 -0000	1.18
>+++ name_table.c	2 Jun 2004 21:34:32 -0000
>@@ -750,7 +750,7 @@
> 			destnode = publ->node;
> 			destport = publ->ref;
> 			if (destport) {
>-				printk("mc table\n");
>+				dbg("mc table\n");
> 				if (in_list_node(mc_head, destnode)) {
> 					if (false ==
> 					    mc_identity_create(mc_head,
>@@ -828,7 +828,7 @@
> 			destnode = publ->node;
> 			destport = publ->ref;
> 			if (destport && (destnode == tipc_own_addr)) {
>-				printk("self table\n");
>+				dbg("self table\n");
> 				if (in_list(mc_head, destport, destnode)) {
> 					if (false ==
> 					    mc_identity_create(mc_head,
>@@ -845,7 +845,7 @@
> 		/*      
> 		   if (destport && (destnode == tipc_own_addr))
> 		   {
>-		   printk("self trans\n");
>+		   dbg("self trans\n");
> 		   if ( false == mc_indenity_create(mc_head,destport,destnode)) {
> 		   spin_unlock_bh(&seq->lock);
> 		   goto not_found;      
>
>  
>