RE: [Tipc-discussion] patch bcast fix in nameseq_deliver

[Ling, X. <xia...@in...>]

It's good fix. I've checked in. Also add some code clean up.
For blink_send_buf_fast's return value, it do has the problem need to be =
fixed.

>-----Original Message-----
>From: tip...@li...=20
>[mailto:tip...@li...] On Behalf=20
>Of Daniel McNeil
>Sent: 2004=C4=EA5=D4=C226=C8=D5 5:28
>To: tipc
>Subject: [Tipc-discussion] patch bcast fix in nameseq_deliver
>
>Jon,
>
>When testing multicast and having 2 processes on the same node
>running my membership code, one process was not getting messages.
>I found another place where getting the number of bytes sent was
>being treated as an error.
>
>Here's the patch to fix nameseq_deliver():
>
>Index: recvbcast.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>RCS file: /cvsroot/tipc/source/unstable/net/tipc/recvbcast.c,v
>retrieving revision 1.18
>diff -u -b -B -p -u -r1.18 recvbcast.c
>--- recvbcast.c	5 May 2004 19:09:03 -0000	1.18
>+++ recvbcast.c	25 May 2004 20:30:53 -0000
>@@ -446,6 +446,7 @@ nameseq_deliver(struct sk_buff *buf, str
> 	struct list_head *pos;
> 	struct mc_identity *mid;
> 	int res =3D TIPC_OK;
>+	int sz =3D msg_data_sz(buf_msg(buf));
>=20
> 	dbg("nameseq_deliver\n");
> 	list_for_each(pos, mc_head) {
>@@ -458,7 +459,7 @@ nameseq_deliver(struct sk_buff *buf, str
> 			msg_set_destport(buf_msg(copymsg), mid->port);
> 			if (port) {
> 				res =3D port_recv_msg(copymsg);
>-				if (res)
>+				if (res !=3D sz)
> 					break;
> 			}
> 		}
>
>
>
>It also looks like blink_send_buf_fast() should be returning the=20
>number of bytes sent.  It sometimes does and sometimes returns TIPC_OK.
>Mark and I are still looking at it.
>
>Daniel
>
>
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: Oracle 10g
>Get certified on the hottest thing ever to hit the market...=20
>Oracle 10g.=20
>Take an Oracle 10g class now, and we'll give you the exam FREE.
>http://ads.osdn.com/?ad_id=3D3149&alloc_id=3D8166&op=3Dclick
>_______________________________________________
>TIPC-discussion mailing list
>TIP...@li...
>https://lists.sourceforge.net/lists/listinfo/tipc-discussion
>