Re: [Tipc-discussion] New file release tipc-1.3.10

[Mark H. <ma...@os...>]

On Thu, 2004-04-29 at 08:15, Jon Maloy wrote:
> Do you suggest that we delay the LKML-announcement until we have done
> these changes ? To replace all the linked lists is intrusive, and it
> may 
> take weeks re-stabilize the code. Otherwise, see my comments below.
> 
> Regards /jon
> 

[ ... ]

> > There shouldn't be ifdefs in .c code
> The ones that are there now are for excluding code that should be
> configurable
> from the Kconfig file. Is there any other way ?

I think that this is supposed to be done in header files. Or in some
cases they aren't needed.  I don't think that the ifdef MODULE code is
needed, for instance, since module.h contains the ifdef inside to do the
right thing.

> > You may have seen documents like these already, but I found a few
> > style/how-to documents on the web for linux kernel/driver code that may
> > be helpful:
> > 
> > http://graphics.cs.ucdavis.edu/~brettw/insight/linuxcodingstyle.html
> > http://www.linuxjournal.com/article.php?sid=5780
> > http://www.linuxdevices.com/articles/AT5340618290.html
> > http://people.redhat.com/arjanv/olspaper.pdf
> > 
> > Also, I think that in the long run, that the 2.4/2.6 ifdef code will
> I see there is one I forgot to remove in driver.c, otherwise I think
> this is already
> done.

You are right.  I didn't count how many there were.


-- 
Mark Haverkamp <ma...@os...>