Re: [Tipc-discussion] New file release tipc-1.3.10

[Mark H. <ma...@os...>]

On Tue, 2004-04-27 at 16:58, Jon Maloy wrote:
> Hi all,
> I just uploaded a new file release to SourceForge.
> I have corrected several bug related to message bundling and
> link changeover, plus a very serious lock bug that sometimes
> caused my processors to hang when they lost contact with each
> other.
> I also corrected a bug in the name/network subscription code,
> so you will now receive an event for all overlapping, already
> existing publications, not only the first one found ;-).
> Some left-out symbols were finally exported as they should.

[ ... ]

> Also, I plan to announce TIPC at the LKML by the end of this week. We must
> admit that the code is still in beta status, but as I understand it this 
> should
> be no problem.

There are still a few things that I think will have to be addressed from
a style/structure point of view before requesting that tipc be
considered for inclusion in the main kernel tree.

Some files still have non-standard indentation (name_table.c for
instance).  There is a shell script in the kernel tree called Lindent
that runs indent to format source files.

The style documents that I have seen say to use the list_head macros
everywhere and not use other methods of linked lists.

There shouldn't be ifdefs in .c code

You may have seen documents like these already, but I found a few
style/how-to documents on the web for linux kernel/driver code that may
be helpful:

http://graphics.cs.ucdavis.edu/~brettw/insight/linuxcodingstyle.html
http://www.linuxjournal.com/article.php?sid=5780
http://www.linuxdevices.com/articles/AT5340618290.html
http://people.redhat.com/arjanv/olspaper.pdf

Also, I think that in the long run, that the 2.4/2.6 ifdef code will
have to be removed and the macro wrappers for things like
kmalloc(k_malloc) will have to be removed.

When you send an announcement, You should also send to
ne...@os... where linux network code is discussed.


-- 
Mark Haverkamp <ma...@os...>