RE: [Tipc-discussion] Re: tipc multicast patch

[Daniel M. <da...@os...>]

Hi,

Mark told me you checked-in your code changes.

Just a few good open source development process suggestions:

  Could you please send email to the tipc list when code check-in's
  are done so all of us know?

  Patches should be reviewed on the list before check in.

  The check-in log messages should describe what actually was fixed.

  Patch early and patch often. (Mark and I debugged code which
  you already had fixes for :( )  Send out patches incrementally
  as you find and fix bugs.


We have not tested > 8 nodes, yet.  We could test that code
by changing the check (we currently have 4 nodes) to a lower
number.  Do you want us to do this?

How/why was the number '8' chosen for broadcast?

Also, Mark and I notice some interesting behavior of the mulicast:

If 2 processes on the same node publish the same port name sequence,
a multicast only goes 1 process on the local node (we have not tried
remote yet).  Is this the intended behavior?  Should all processes
on all nodes get it?  (I do not know if your latest check-in affects
this behavior)

Thanks,

Daniel