Re: [tipc-discussion] [PATCH] tipc: cleanup unused function

[Jon M. <jm...@re...>]

On 6/16/22 05:32, Hoang Le wrote:
> tipc_dest_list_len() is not being called anywhere. Clean it up.
>
> Signed-off-by: Hoang Le <hoa...@de...>
> ---
>   net/tipc/name_table.c | 11 -----------
>   net/tipc/name_table.h |  1 -
>   2 files changed, 12 deletions(-)
>
> diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
> index 1d8ba233d047..d1180370fdf4 100644
> --- a/net/tipc/name_table.c
> +++ b/net/tipc/name_table.c
> @@ -1202,14 +1202,3 @@ void tipc_dest_list_purge(struct list_head *l)
>   		kfree(dst);
>   	}
>   }
> -
> -int tipc_dest_list_len(struct list_head *l)
> -{
> -	struct tipc_dest *dst;
> -	int i = 0;
> -
> -	list_for_each_entry(dst, l, list) {
> -		i++;
> -	}
> -	return i;
> -}
> diff --git a/net/tipc/name_table.h b/net/tipc/name_table.h
> index 259f95e3d99c..3bcd9ef8cee3 100644
> --- a/net/tipc/name_table.h
> +++ b/net/tipc/name_table.h
> @@ -151,6 +151,5 @@ bool tipc_dest_push(struct list_head *l, u32 node, u32 port);
>   bool tipc_dest_pop(struct list_head *l, u32 *node, u32 *port);
>   bool tipc_dest_del(struct list_head *l, u32 node, u32 port);
>   void tipc_dest_list_purge(struct list_head *l);
> -int tipc_dest_list_len(struct list_head *l);
>   
>   #endif
Acked-by: Jon Maloy <jm...@re...>