Re: [tipc-discussion] [PATCH net-next] tipc: remove inputq from tipc_bc_base

[Xin L. <luc...@gm...>]

On Mon, Jun 6, 2022 at 11:20 PM Tung Quang Nguyen
<tun...@de...> wrote:
>
> > -----Original Message-----
> > From: Xin Long <luc...@gm...>
> > Sent: Tuesday, June 7, 2022 12:57 AM
> > To: tip...@li...
> > Subject: Re: [tipc-discussion] [PATCH net-next] tipc: remove inputq from tipc_bc_base
> >
> > fix Jon's email address.
> >
> > On Mon, Jun 6, 2022 at 1:52 PM Xin Long <luc...@gm...> wrote:
> > >
> > > After Commit 2af5ae372a4b ("tipc: clean up unused code and structures"),
> > > there is no place really using tn->bcbase->inputq. This patch is to
> > > delete this member from struct tipc_bc_base.
>
> We cannot delete this queue because it is currently used to contain wakeup messages for broadcast send link.
> See this calling flow: tipc_rcv() --> tipc_node_bc_sync_rcv() --> tipc_bcast_sync_rcv() --> tipc_link_bc_ack_rcv() --> link_prepare_wakeup()
> link_prepare_wakeup() copies wakeup messages from the wakeup queue to the tipc_bc_base->inputq. Then, the wakeup is done in tipc_bcast_sync_rcv()
>
You're right, thanks!