Re: [tipc-discussion] [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

[Xue, Y. <Yin...@wi...>]

This patch looks good to me.

-----Original Message-----
From: Gustavo A. R. Silva <gus...@ke...> 
Sent: Friday, March 5, 2021 5:25 PM
To: Jon Maloy <jm...@re...>; Xue, Ying <Yin...@wi...>; David S. Miller <da...@da...>; Jakub Kicinski <ku...@ke...>
Cc: ne...@vg...; tip...@li...; lin...@vg...; Gustavo A. R. Silva <gus...@ke...>; lin...@vg...
Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gus...@ke...>
---
 net/tipc/link.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
 			break;
 		case LINK_FAILOVER_BEGIN_EVT:
 			l->state = LINK_FAILINGOVER;
+			break;
 		case LINK_FAILURE_EVT:
 		case LINK_RESET_EVT:
 		case LINK_ESTABLISH_EVT:
--
2.27.0