Re: [tipc-discussion] [net-next v2 00/16] tipc: cleanups and simplifications

[Xin L. <luc...@gm...>]

On Sun, Feb 28, 2021 at 12:56 AM <jm...@re...> wrote:
>
> From: Jon Maloy <jm...@re...>
>
> We make a number of simplifications and cleanups, especially to call signatures
> in the binding table. This makes the code easier to understand and serves as a
> preparation for an upcoming functional addition.
>
> v2:
>    - Eliminated sparse warnings, as per feedback from Hoang
>    - Fixed some typos, as per feedback from Tung
>    - Fixed some issues noted by Xin:
>      #2/16: Moved spinlock.
>      #4/16: Added scope check and used tipc_uaddr() in tipc_sk_join()
>      #5/16: Eliminated 'addrtype' from struct publication (for now).
>      #6/16: 'node number' represented as decimal in some places and
>             hex in others. I will fix that in a separate patch later.
>      #8/16: Re-introduce use of node2scope(). This function is needed
>             later.
>      #13/16: This change does not look motivated right now, as stated
>              in the commit log, but will be needed later. I kept it,
>              just because of the consequences of removing it now and
>              having to re-introduce it later.
>      #14/16: Made tipc_sub_check_overlap() static, as also reported
>              by sparse.
>
> Jon Maloy (16):
>   tipc: re-organize members of struct publication
>   tipc: move creation of publication item one level up in call chain
>   tipc: introduce new unified address type for internal use
>   tipc: simplify signature of tipc_namtbl_publish()
>   tipc: simplify call signatures for publication creation
>   tipc: simplify signature of tipc_nametbl_withdraw() functions
>   tipc: rename binding table lookup functions
>   tipc: refactor tipc_sendmsg() and tipc_lookup_anycast()
>   tipc: simplify signature of tipc_namtbl_lookup_mcast_sockets()
>   tipc: simplify signature of tipc_nametbl_lookup_mcast_nodes()
>   tipc: simplify signature of tipc_nametbl_lookup_group()
>   tipc: simplify signature of tipc_service_find_range()
>   tipc: simplify signature of tipc_find_service()
>   tipc: simplify api between binding table and topology server
>   tipc: add host-endian copy of user subscription to struct
>     tipc_subscription
>   tipc: remove some unnecessary warnings
>
>  net/tipc/addr.h       |  44 +++++
>  net/tipc/msg.c        |  23 ++-
>  net/tipc/name_distr.c |  91 +++++----
>  net/tipc/name_table.c | 426 +++++++++++++++++++++---------------------
>  net/tipc/name_table.h |  63 +++----
>  net/tipc/net.c        |   8 +-
>  net/tipc/node.c       |  28 +--
>  net/tipc/socket.c     | 319 ++++++++++++++++---------------
>  net/tipc/subscr.c     |  84 +++++----
>  net/tipc/subscr.h     |  12 +-
>  10 files changed, 573 insertions(+), 525 deletions(-)
>
>
>
> _______________________________________________
> tipc-discussion mailing list
> tip...@li...
> https://lists.sourceforge.net/lists/listinfo/tipc-discussion
Acked-by: Xin Long <luc...@gm...>