Re: [tipc-discussion] [net-next v2 1/2] tipc: convert dest node's address to network order

[Jon M. <jm...@re...>]

Hi Hoang,
I noticed that this series is not upstream yet. Did I forget to ack it?
Series
Acked-by: Jon Maloy <jm...@re...>

On 1/18/21 3:08 AM, Hoang Huu Le wrote:
> From: Hoang Le <hoa...@de...>
>
> (struct tipc_link_info)->dest is in network order (__be32), so we must
> convert the value to network order before assigning. The problem detected
> by sparse:
>
> net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)
> net/tipc/netlink_compat.c:699:24:    expected restricted __be32 [usertype] dest
> net/tipc/netlink_compat.c:699:24:    got int
>
> Acked-by: Jon Maloy <jm...@re...>
> Signed-off-by: Hoang Le <hoa...@de...>
> ---
>   net/tipc/netlink_compat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
> index 5a1ce64039f7..0749df80454d 100644
> --- a/net/tipc/netlink_compat.c
> +++ b/net/tipc/netlink_compat.c
> @@ -696,7 +696,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg,
>   	if (err)
>   		return err;
>   
> -	link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
> +	link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST]));
>   	link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
>   	nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME],
>   		    TIPC_MAX_LINK_NAME);