Re: [tipc-discussion] [net-next] tipc: remove duplicated code in tipc_msg_create

[Jon M. <jm...@re...>]

On 1/25/21 3:58 AM, Hoang Huu Le wrote:
> Remove a duplicate code checking for header size in tipc_msg_create() as
> it's already being done in tipc_msg_init().
>
> Signed-off-by: Hoang Huu Le <hoa...@de...>
> ---
>   net/tipc/msg.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/net/tipc/msg.c b/net/tipc/msg.c
> index 2aca86021df5..e9263280a2d4 100644
> --- a/net/tipc/msg.c
> +++ b/net/tipc/msg.c
> @@ -117,10 +117,6 @@ struct sk_buff *tipc_msg_create(uint user, uint type,
>   	msg_set_origport(msg, oport);
>   	msg_set_destport(msg, dport);
>   	msg_set_errcode(msg, errcode);
> -	if (hdr_sz > SHORT_H_SIZE) {
> -		msg_set_orignode(msg, onode);
> -		msg_set_destnode(msg, dnode);
> -	}
>   	return buf;
>   }
>   
Acked-by: Jon Maloy <jm...@re...>