Re: [tipc-discussion] [next v2] tipc: fix incorrect setting window for bcast link

[Jon M. <jm...@re...>]

On 10/14/20 3:07 AM, Hoang Huu Le wrote:
> In commit 16ad3f4022bb
> ("tipc: introduce variable window congestion control"), we applied
> the algorithm to select window size from minimum window to the
> configured maximum window for unicast link, and, besides we chose
> to keep the window size for broadcast link unchanged and equal (i.e
> fix window 50)
>
> However, when setting maximum window variable via command, the window
> variable was re-initialized to unexpect value (i.e 32).
>
> We fix this by updating the fix window for broadcast as we stated.
>
> Fixes: 16ad3f4022bb ("tipc: introduce variable window congestion control")
> Signed-off-by: Hoang Huu Le <hoa...@de...>
> ---
>   net/tipc/bcast.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index c77fd13e2777..bc88f21ec0b2 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -589,7 +589,7 @@ static int tipc_bc_link_set_queue_limits(struct net *net, u32 max_win)
>   	if (max_win > TIPC_MAX_LINK_WIN)
>   		return -EINVAL;
>   	tipc_bcast_lock(net);
> -	tipc_link_set_queue_limits(l, BCLINK_WIN_MIN, max_win);
> +	tipc_link_set_queue_limits(l, tipc_link_min_win(l), max_win);
>   	tipc_bcast_unlock(net);
>   	return 0;
>   }
Acked-by: Jon Maloy <jm...@re...>