Re: [tipc-discussion] [net-next] tipc: simplify trivial boolean return

[Jon M. <jm...@re...>]

Acked-by: Jon Maloy <jm...@re...>

On 3/5/20 7:52 AM, Xue, Ying wrote:
> Acked-by: Ying Xue <yin...@wi...>
>
> -----Original Message-----
> From: Hoang Le [mailto:hoa...@de...]
> Sent: Friday, February 21, 2020 12:49 PM
> To: jm...@re...; ma...@do...; tip...@li...; Xue, Ying
> Subject: [net-next] tipc: simplify trivial boolean return
>
> Checking and returning 'true' boolean is useless as it will be
> returning at end of function
>
> Signed-off-by: Hoang Le <hoa...@de...>
> ---
>   net/tipc/msg.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/net/tipc/msg.c b/net/tipc/msg.c
> index 0d515d20b056..4d0e0bdd997b 100644
> --- a/net/tipc/msg.c
> +++ b/net/tipc/msg.c
> @@ -736,9 +736,6 @@ bool tipc_msg_lookup_dest(struct net *net, struct sk_buff *skb, int *err)
>   	msg_set_destport(msg, dport);
>   	*err = TIPC_OK;
>   
> -	if (!skb_cloned(skb))
> -		return true;
> -
>   	return true;
>   }
>   

--