Re: [tipc-discussion] [PATCH v2 4/5] tipc: introduce TIPC encryption & authentication

[Ying X. <yin...@wi...>]

On 11/5/19 6:50 PM, Tuong Lien wrote:
>  void tipc_bearer_xmit(struct net *net, u32 bearer_id,
>  		      struct sk_buff_head *xmitq,
> -		      struct tipc_media_addr *dst)
> +#ifdef CONFIG_TIPC_CRYPTO
> +		      struct tipc_media_addr *dst,
> +		      struct tipc_node *__dnode
> +#else
> +		      struct tipc_media_addr *dst
> +#endif
> +		      )

To make code simpler, I think we can directly add one new parameter (ie,
__dnode) no matter whether CONFIG_TIPC_CRYPTO is enabled or not.

When CONFIG_TIPC_CRYPTO is disabled, we just pass NULL to "__dnode"
parameter. As a consequence, we don't need to use CONFIG_TIPC_CRYPTO
config to separate the two different situations of whether
CONFIG_TIPC_CRYPTO is enabled or not whenever tipc_bearer_xmit() is called.