Re: [tipc-discussion] [PATCH] tipc: fix modprobe tipc failed after switch order of device registration

[David M. <da...@da...>]

From: hujunwei <huj...@hu...>
Date: Fri, 17 May 2019 19:27:34 +0800

> From: Junwei Hu <huj...@hu...>
> 
> Error message printed:
> modprobe: ERROR: could not insert 'tipc': Address family not
> supported by protocol.
> when modprobe tipc after the following patch: switch order of
> device registration, commit 7e27e8d6130c
> ("tipc: switch order of device registration to fix a crash")
> 
> Because sock_create_kern(net, AF_TIPC, ...) is called by
> tipc_topsrv_create_listener() in the initialization process
> of tipc_net_ops, tipc_socket_init() must be execute before that.
> 
> I move tipc_socket_init() into function tipc_init_net().
> 
> Fixes: 7e27e8d6130c
> ("tipc: switch order of device registration to fix a crash")
> Signed-off-by: Junwei Hu <huj...@hu...>
> Reported-by: Wang Wang <wan...@hu...>
> Reviewed-by: Kang Zhou <zho...@hu...>
> Reviewed-by: Suanming Mou <mou...@hu...>

Applied.