Re: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired subscription

[Jon M. <jon...@er...>]

From: Parthasarathy Bhuvaragan
Sent: Tuesday, March 21, 2017 04:20 AM
To: Jon Maloy <jon...@er...>; John Thompson <tho...@gm...>
Cc: tip...@li...
Subject: Re: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired subscription


Hi Jon,



Ok, I will submit it today.



I usually add the Fixes tag in the tag section instead of specifying it in the body of the commit message like you do.

I followed the instructions specified in: http://lxr.free-electrons.com/source/Documentation/SubmittingPatches?v=3.16#L135

This commit to net has the following tag:

Fixes: d094c4d5f5c7 ("tipc: add subscription refcount to avoid invalid delete")



No problem. I didn't notice that.



///jon



/Partha

________________________________
From: Jon Maloy
Sent: Monday, March 20, 2017 8:30 PM
To: Jon Maloy; Parthasarathy Bhuvaragan; John Thompson
Cc: tip...@li...<mailto:tip...@li...>
Subject: RE: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired subscription

BTW, I think you should add a reference to the patch where the subscription refcount was introduced in the log message, so that Andrew will know how far back he should apply this patch on "stable".

///jon


> -----Original Message-----
> From: Jon Maloy [mailto:jon...@er...]
> Sent: Monday, March 20, 2017 03:18 PM
> To: Parthasarathy Bhuvaragan <par...@er...<mailto:par...@er...>>;
> John Thompson <tho...@gm...<mailto:tho...@gm...>>
> Cc: tip...@li...<mailto:tip...@li...>
> Subject: Re: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired
> subscription
>
> No objections. Just go ahead.
>
> ///jon
>
>
> From: Parthasarathy Bhuvaragan
> Sent: Monday, March 20, 2017 12:00 PM
> To: Jon Maloy <jon...@er...<mailto:jon...@er...>>; John Thompson
> <tho...@gm...<mailto:tho...@gm...>>
> Cc: Ying Xue <yin...@wi...<mailto:yin...@wi...>>; tipc-
> dis...@li...<mailto:dis...@li...>
> Subject: Re: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired
> subscription
>
>
> Hi,
>
> In that case I plan to send the only the first fix to net:
>
>   tipc: advance the time of calling tipc_nametbl_unsubscribe
>
> Then wait till net is merged to netnext and submit the following to netnext:
>    tipc: advance the time of deleting subscription from
> subscriber->subscrp_list
>    tipc: adjust the policy of holding subscription kref
>
> Any objections?
>
> /Partha
>
> ________________________________
> From: Jon Maloy
> Sent: Monday, March 20, 2017 1:25:57 PM
> To: John Thompson; Parthasarathy Bhuvaragan
> Cc: Ying Xue; tip...@li...<mailto:tipc-<mailto:tip...@li...%3cmailto:tipc->
> dis...@li...<mailto:dis...@li...>>
> Subject: RE: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired
> subscription
>
> Series acked by me. Please send to 'net' since this problem really occurs
> frequently even in the released version.
>
> ///jon
>
>
> From: John Thompson [mailto:tho...@gm...]
> Sent: Sunday, March 19, 2017 09:19 PM
> To: Parthasarathy Bhuvaragan
> <par...@er...<mailto:parthasarathy.bhuvaraga
<mailto:par...@er...%3cmailto:parthasarathy.bhuvaraga%0b>> n...@er...<mailto:n...@er...>>>
> Cc: Ying Xue <yin...@wi...<mailto:yin...@wi...<mailto:yin...@wi...%3cmailto:yin...@wi...>>>;
> tip...@li...<mailto:tipc-<mailto:tip...@li...%3cmailto:tipc->
> dis...@li...<mailto:dis...@li...>>; Jon Maloy
> <jon...@er...<mailto:jon...@er...<mailto:jon...@er...%3cmailto:jon...@er...>>>
> Subject: Re: [tipc-discussion] [PATCH v2 net-next 6/6] tipc: delete expired
> subscription
>
>
> On Fri, Mar 17, 2017 at 3:44 PM, John Thompson
> <tho...@gm...<mailto:tho...@gm...<mailto:tho...@gm...%3cmailto:tho...@gm...>>> wrote:
>
>
> On Fri, Mar 17, 2017 at 9:35 AM, John Thompson
> <tho...@gm...<mailto:tho...@gm...<mailto:tho...@gm...%3cmailto:tho...@gm...>>> wrote:
>
>
> On Thu, Mar 16, 2017 at 1:45 AM, Parthasarathy Bhuvaragan
> <par...@er...<mailto:parthasarathy.bhuvaraga
<mailto:par...@er...%3cmailto:parthasarathy.bhuvaraga%0b>> n...@er...<mailto:n...@er...>>> wrote:
>
> Hi John,
>
> Can you run your test with my series and provide some feedback?
> Hi Partha
> I have started running some tests and will be in touch later today with initial
> results.
> Thanks
> Jt
>
> Hi Partha,
> My testing is looking good.  I have generally seen problems reasonably
> quickly.  This patch series seems good.  I will run a longer run test over the
> weekend to be certain but it should be ok.
>
> Thanks,
> JT
> Hi Partha,
>
> My testing over the weekend has looked good. I have not seen any soft
> lockups or other errors of any form.
>
> JT
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most engaging
> tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> tipc-discussion mailing list
> tip...@li...<mailto:tip...@li...>
> https://lists.sourceforge.net/lists/listinfo/tipc-discussion