|
From: Jon M. <ma...@do...> - 2013-10-20 20:38:25
|
On 09/30/2013 10:38 AM, Ying Xue wrote: > There are a mix of function prototypes with and without extern in the > TIPC source code, however, even though we don't use extern keyword > with declaration of function, it is present there from compiler view. > Therefore, standardize on not using extern for all function prototypes. > Additionally the change also refers to the commit(ID: 5c15257f). Joe Perches has already done this for us, so we can skip this patch. ///jon > > Signed-off-by: Ying Xue <yin...@wi...> > --- > net/tipc/core.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/net/tipc/core.h b/net/tipc/core.h > index be72f8c..bef34ea 100644 > --- a/net/tipc/core.h > +++ b/net/tipc/core.h > @@ -90,21 +90,21 @@ extern int tipc_random __read_mostly; > /* > * Routines available to privileged subsystems > */ > -extern int tipc_core_start_net(unsigned long); > -extern int tipc_handler_start(void); > -extern void tipc_handler_stop(void); > -extern int tipc_netlink_start(void); > -extern void tipc_netlink_stop(void); > -extern int tipc_socket_init(void); > -extern void tipc_socket_stop(void); > -extern int tipc_sock_create_local(int type, struct socket **res); > -extern void tipc_sock_release_local(struct socket *sock); > -extern int tipc_sock_accept_local(struct socket *sock, > - struct socket **newsock, int flags); > +int tipc_core_start_net(unsigned long); > +int tipc_handler_start(void); > +void tipc_handler_stop(void); > +int tipc_netlink_start(void); > +void tipc_netlink_stop(void); > +int tipc_socket_init(void); > +void tipc_socket_stop(void); > +int tipc_sock_create_local(int type, struct socket **res); > +void tipc_sock_release_local(struct socket *sock); > +int tipc_sock_accept_local(struct socket *sock, struct socket **newsock, > + int flags); > > #ifdef CONFIG_SYSCTL > -extern int tipc_register_sysctl(void); > -extern void tipc_unregister_sysctl(void); > +int tipc_register_sysctl(void); > +void tipc_unregister_sysctl(void); > #else > #define tipc_register_sysctl() 0 > #define tipc_unregister_sysctl() > @@ -201,6 +201,6 @@ static inline struct tipc_msg *buf_msg(struct sk_buff *skb) > return (struct tipc_msg *)skb->data; > } > > -extern struct sk_buff *tipc_buf_acquire(u32 size); > +struct sk_buff *tipc_buf_acquire(u32 size); > > #endif |