Re: [tipc-discussion] [PATCH net-next v3 09/12] tipc: convert tipc_bearers array to pointer array

[Ying X. <yin...@wi...>]

On 10/07/2013 04:50 PM, Erik Hugne wrote:
> On Mon, Sep 30, 2013 at 04:38:21PM +0800, Ying Xue wrote:
>> As tipc_bearers will be protected by RCU lock, tipc_bearers is
>> defined as static array where the data of tipc_bearer struct is
>> located in each array element. But since static array has not seen
>> with RCU, tipc_bearers should be redefined to a pointer array where
>> a pointer pointed to dynamically allocated instance of tipc_bearer
>> struct is located in each array element, allowing the pointer
>> array to be protected with RCU.
>>
>> Signed-off-by: Ying Xue <yin...@wi...>
> 
> I find it hard to understand from the commitmsg what you're doing, and for what 
> purpose. Maybe rephrase it to something like:
> 

My puspose is to mainly describe why we need to convert tipc_bearer
array to bearer list :). Essentially its resaon is very simple because
RCU lock cannot protect static array.

> "As part of the effort to introduce RCU protection for the bearer list,
> we first need to change it to a list of pointers."
> 
> Maybe a little short though..
> 

OK, I will adopt your suggestion if nobody object to..

Regards,
Ying

> //E
>