From: Ying X. <yin...@wi...> - 2012-11-01 09:58:48
|
Erik Hugne wrote: > >> Reseting link is not a good idea. If we are not in the worst case, we >> definitely don't do that. > This is actually a worst case. > We have dropped packets that are already acked before they are > delivered to user (all frags have not been received yet) we cannot > recover from this situation. > >> I also cannot understand why link_check_defragm_bufs() is used. We >> should not flush acked packets in general except that its link will be >> reset. >> > > Either we have to reset the link, or we remove the checking of stale > defragm_bufs. > It's better to remove the checking. When link is reset as the number of link timeout reaches its abort limit, the defragm_bufs will be purged. So it's unnecessary to check defragm_bufs periodically. > //E > > |