Menu
▾
▴
Re: [tipc-discussion] FW: WR to support TIPC with a new patch delivered by Motorola (TSR 735464/SPR WIND00160708)
|
From: Stephens, A. <all...@wi...> - 2009-04-01 17:51:11
|
Hi Tara: What Motorola needs to do is: 1) Clone David Miller's net-next-2.6 git repository. eg. git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6.git This creates a baseline against which their changes will be created (i.e. against the most recent TIPC 1.6 codebase). 2) Code up and test their enhancement and commit it to git. There are lots of websites out there that describe how to use git for Linux kernel development. But be aware that the learning curve can be substantial! It took me quite a while before I became reasonably comfortable with using it. 3) Create a patchfile for their commit. eg. git format-patch HEAD^..HEAD (produces patch for latest commit) 4) Test the patch. See http://linux.yyz.us/patch-format.html for some tips on what a patch email should look like. Email the patch to yourself and then apply it to (a different branch of) your git repository to ensure that it applies cleanly. 5) Send the patch email to tip...@li.... What will then happen is: 6) The members of the TIPC Working Group will evaluate the patch. It necessary, we may request changes that will require re-submission of the patch. (Note: Almost no-one ever gets their change accepted the first time. The first time I submitted something to the kernel it was rejected 3 times before I got it into proper shape!) 7) I will formally approve the patch and forward it to the Linux net-dev mailing list. It will again be reviewed, but the chances of problems at this stage are greatly reduced. 8) Once David Miller accepts the patch, I'll integrate it into the TIPC 1.7 code base. 9) Once the patch is in TIPC 1.7 Bruce will pull it into WR-Linux. Regards, Al =========== Example of Linux patchfile: This patch eliminates an unneeded parameter when creating a low-level TIPC port object. Instead of returning both the pointer to the port structure and the port's reference ID, it now returns only the pointer since the port structure contains the reference ID as one of its fields. Signed-off-by: Allan Stephens <all...@wi...> --- include/net/tipc/tipc_port.h | 13 +++---------- net/tipc/port.c | 28 ++++++++++------------------ net/tipc/socket.c | 15 +++++++-------- 3 files changed, 20 insertions(+), 36 deletions(-) diff --git a/include/net/tipc/tipc_port.h b/include/net/tipc/tipc_port.h index 9923e41..c54917c 100644 --- a/include/net/tipc/tipc_port.h +++ b/include/net/tipc/tipc_port.h @@ -2,7 +2,7 @@ * include/net/tipc/tipc_port.h: Include file for privileged access to TIPC ports * * Copyright (c) 1994-2007, Ericsson AB - * Copyright (c) 2005-2007, Wind River Systems + * Copyright (c) 2005-2008, Wind River Systems * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -75,17 +75,10 @@ struct tipc_port { }; [rest of patch omitted] > -----Original Message----- > From: Fahey, Tara > Sent: Wednesday, April 01, 2009 10:15 AM > To: Ashfield, Bruce > Cc: Stephens, Allan; Koldoff, Arleen; Wessel, Jason; Davis, Bradley > Subject: RE: FW: WR to support TIPC with a new patch > delivered by Motorola (TSR 735464/SPR WIND00160708) > > Bruce, > Thank you for the detailed explanation on how to monitor progress. > I will convey the steps to Motorola so they are aware. > > The customer is asking what on their part they need to do to > submit the patch to the TIPC project. > > I took a look at the Technical Support Page at: > http://tipc.sourceforge.net/support.html > and the guidelines for submitting patches states that it > still needs to be completed. > > Can you provide some guidelines that I can provide to > Motorola on how to go about submitting the patch and what > other information is necessary that the TIPC community will > be looking for on the submission? > > Thanks again for your assistance, > Tara > > -----Original Message----- > From: Bruce Ashfield [mailto:bru...@wi...] > Sent: Tuesday, March 31, 2009 7:50 PM > To: Fahey, Tara > Cc: Stephens, Allan; Koldoff, Arleen; Wessel, Jason; Davis, Bradley > Subject: Re: FW: WR to support TIPC with a new patch > delivered by Motorola (TSR 735464/SPR WIND00160708) > > Fahey, Tara wrote: > > Hi Al, > > I have provided Motorola with the explanation of the > process and the > > steps you provided below. > > > > They do have a question about how they can monitor and follow up on > > the progress of this once they submit the patch. > > I'll jump in here, Al can clarify/correct if need be. > > Communications will be on the various mailing lists with > direct copies to the submitter of the patch. So monitoring > the progress is normally just done via email. The initial > submission to the TIPC project will be the most obvious phase. > > As the patch transitions from the tipc project to the > mainline kernel, there may or may not be direct email to the > submitter of the patch to the tipc project. Chances are there > wouldn't be direct email. In that case, monitoring the netdev > mailing list for the tipc submissions would be required. In > this phase either Al and/or myself can do the monitoring, > since I watch the list and Al might be the one pushing the > patches to the mainline kernel. Either way, we can be sure > that the customer is aware of the process. > > Also note that once the patch is sent to the tipc project, I > can also start the process of merging it into Wind River's > newer development releases to ensure that the patch is > available for an appropriate release if the timeframes don't > match the requirements. > > Bruce > > > > > I am not familiar with this process, so I hope you can possibly > > provide the answer to their question? > > > > Thank you for all your help, > > Tara > > > > -----Original Message----- > > From: Stephens, Allan > > Sent: Monday, March 30, 2009 4:06 PM > > To: Fahey, Tara; Ashfield, Bruce; Koldoff, Arleen > > Cc: Wessel, Jason; Davis, Bradley > > Subject: RE: FW: WR to support TIPC with a new patch delivered by > > Motorola (TSR 735464/SPR WIND00160708) > > > > I'd think that we'd be talking about a matter of weeks > here, possibly > > even 2 or 3 months. The big unknown here occurs in steps 4 and 5, > > which is outside of Wind River's control. There are "blackout" > > periods for submitting new capabilities to the Linux kernel > that arise > > from time to time which could stall the process for several weeks. > > > > Regards, > > Al > > > >> -----Original Message----- > >> From: Fahey, Tara > >> Sent: Monday, March 30, 2009 4:57 PM > >> To: Stephens, Allan; Ashfield, Bruce; Koldoff, Arleen > >> Cc: Wessel, Jason; Davis, Bradley > >> Subject: RE: FW: WR to support TIPC with a new patch delivered by > >> Motorola (TSR 735464/SPR WIND00160708) > >> > >> Hi Allan, > >> Can you "guesstimate" how long steps 1-6 will take (on > >> average) before we arrive at step 7? > >> Just want to get the answer to that in case Motorola asks, > so we can > >> set their expectations correctly. > >> > >> Thanks, > >> Tara > >> > >> -----Original Message----- > >> From: Stephens, Allan > >> Sent: Monday, March 30, 2009 3:53 PM > >> To: Ashfield, Bruce; Koldoff, Arleen > >> Cc: Fahey, Tara; Wessel, Jason; Davis, Bradley > >> Subject: RE: FW: WR to support TIPC with a new patch delivered by > >> Motorola (TSR 735464/SPR WIND00160708) > >> > >> As Bruce indicated, having Motorola submit the patch to the TIPC > >> Working Group is essential. I brought up this patch > proposal at last > >> week's working group meeting, and the response from > several attendees > >> was the same -- "this patch needs to be reviewed (and potentially > >> revised) by the TIPC community as a whole so that it can > be properly > >> integrated into TIPC". > >> > >> From the TIPC project team perspective, the flow of > activity should > >> probably be: > >> > >> 1) Motorla submits patch to TIPC mailing list > >> 2) TIPC Working Group members review patch; rework may be required > >> 3) TIPC Working Group submits patch to Linux kernel networking team > >> 4) Linux kernel networking team reviews patch; rework may > be required > >> 5) Linux kernel team integrates patch into Linux kernel > >> 6) TIPC Working Group integrates patch into TIPC project > >> 7) Bruce integrates patch into WR-Linux > >> > >> Although this may seem like a lot of steps, it's the best way to > >> ensure that the patch will get in where it's needed and we > won't have > >> any problems with it in the future. > >> > >> Regards, > >> Al > >> > >>> -----Original Message----- > >>> From: Bruce Ashfield [mailto:bru...@wi...] > >>> Sent: Monday, March 30, 2009 4:30 PM > >>> To: Koldoff, Arleen > >>> Cc: Fahey, Tara; Wessel, Jason; Stephens, Allan; Davis, Bradley > >>> Subject: Re: FW: WR to support TIPC with a new patch delivered by > >>> Motorola (TSR 735464/SPR WIND00160708) > >>> > >>> Koldoff, Arleen wrote: > >>>> Hello Bruce, > >>>> > >>>> We understand that this isn't being maintained as part of > >> standard > >>>> product. Which is why, per Jason's recommendation, we > >>> contacted you > >>>> to see what the correct process would be to get the ball > >>> rolling on this. > >>>> Motorola has requested this to be part of standard product > >>> so that it > >>>> can be supported by the support organization going forward. > >>>> > >>>> What else do you need from us or what do we need to do in > >> order to > >>>> move forward? > >>> Just the suggestion of a person at the customer who can fill in a > >>> patch header that describes the change and what problem it solves. > >>> > >>> We'd also want to see what sort of testing/use cases this > has been > >>> used in. This is key, since we need to be able to test that the > >>> functionality works for us if we are to carry/support the patch. > >>> > >>> And finally a submission to the tipc project at the same > time as we > >>> get those updates would be wise. With those changes, Al > >> could look at > >>> them in the upstream TIPC context and I can look at them in > >> upstream > >>> and Wind River Linux commercial context. > >>> > >>> Bruce > >>> > >>>> Thanks for your help and guidance!!! > >>>> > >>>> Arleen > >>>> > >>>> -----Original Message----- > >>>> From: Davis, Bradley > >>>> Sent: Monday, March 30, 2009 3:16 PM > >>>> To: Ashfield, Bruce; Fahey, Tara > >>>> Cc: Koldoff, Arleen; Stephens, Allan > >>>> Subject: RE: WR to support TIPC with a new patch delivered > >>> by Motorola > >>>> (TSR 735464/SPR WIND00160708) > >>>> > >>>> Motorola proposed patch attached. > >>>> > >>>>> -----Original Message----- > >>>>> From: Bruce Ashfield [mailto:bru...@wi...] > >>>>> Sent: Monday, March 30, 2009 2:11 PM > >>>>> To: Fahey, Tara > >>>>> Cc: Davis, Bradley; Koldoff, Arleen; Stephens, Allan > >>>>> Subject: Re: WR to support TIPC with a new patch delivered by > >>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>> > >>>>> Fahey, Tara wrote: > >>>>>> Hi Brad, > >>>>>> Thanks for the information. I think what we may need to do is > >>>>>> escalate the issue up to engineering (eg. Bruce and > >>> Allan) and let > >>>>>> them make that call since Bruce and Allan stated that they > >>>>> recommend > >>>>>> against supporting non-standard patches and that the proper > >>>>> procedure > >>>>>> is to submit the patch to the TIPC project as recommended. > >>>>> They also > >>>>>> stated that they have a policy of not carrying specific > >>>>> patches unless > >>>>>> absolutely necessary. > >>>>>> There will have to be some special attention paid to this > >>>>> as they want > >>>>>> it in there current environment, which is as > >>>>>> follows: > >>>>>> > >>>>>> Based on PNE 1.5 with an additional layer, K21 which > >> updates the > >>>>>> kernel to 2.6.21.7. > >>>>> We aren't maintaining this layer as part of standard > >>> product at all. > >>>>> If this is the only required destination for the patch, > >> then there > >>>>> are > >>>>> some resources in sustaining (and > >>>>> JasonW) that can take care of any integration. > >>>>> > >>>>> If we want the patch to propagate to newer versions of the > >>> product, > >>>>> the suggestion is still the same, we should submit the > >>> patch to TIPC > >>>>> and to Wind River at the same time. There's no guarantee > >>> that it'll > >>>>> merge as-is, so someone on the customer side should be > >>> identified to > >>>>> answer any questions that may arise. > >>>>> > >>>>> Wind River Linux tracks the upstream TIPC source base in a > >>>>> 1:1 manner for 2.0, 3.0, etc, so we would only carry a > >>> customization > >>>>> for as short a time as possible, since it makes us partially > >>>>> incompatible with other tipc nodes. > >>>>> > >>>>>> > >>>>>> Bruce and Allan, > >>>>>> Do you need any other information in addition to the patch > >>>>> to get this > >>>>>> request implemented into the standard product. > >>>>> I still haven't seen the patch, was it sent to Al or myself ? > >>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Monday, March 30, 2009 1:34 PM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a new patch delivered > >>>>> by Motorola > >>>>>> (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> He has the actual patch they're using - better than just > >>> the diffs. > >>>>>> Since I have the attention of Oscar, do I still need to be > >>>>> making the > >>>>>> case they subit patches to the tipc project, or are we > >>>>> thinking about > >>>>>> supporting the patch? > >>>>>> > >>>>>> Thanks, > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Monday, March 30, 2009 12:19 PM > >>>>>> To: Davis, Bradley > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a new > >> patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Thanks Brad for the update. > >>>>>> What exactly is the info in regards to that Oscar is > >>>>> collecting for > >>>>>> you? > >>>>>> > >>>>>> Thanks, > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Monday, March 30, 2009 1:18 PM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a new > >> patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Sorry, I should have contacted Oscar earlier. I > >>>>> mistakenly thought > >>>>>> this was Terry's project alone. > >>>>>> I've already attached the proper diffs to the defect > >>>>> and Oscar is > >>>>>> collecting additional info to send me. > >>>>>> > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Monday, March 30, 2009 9:57 AM > >>>>>> To: Davis, Bradley > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a new > >>>>> patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Brad, > >>>>>> Can you attempt to get the information from > >>>>> either Oscar or Carlos > >>>>>> since Terry is out? > >>>>>> If you need my assistance, please let me know. > >>>>>> > >>>>>> Thanks, > >>>>>> Tara > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Monday, March 30, 2009 10:43 AM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a new > >>>>> patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Finally a reply from Terry but... it > >> was an OOO message: > >>>>>> " I'm on PTO" > >>>>>> > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Monday, March 30, 2009 9:28 AM > >>>>>> To: Davis, Bradley > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a > >>>>> new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Thanks Brad - I appreciate it! > >>>>>> You may want to stress to Terry that > >>>>> this information is necessary > >>>>>> to provide to engineering in order to > >>>>>> escalate the issue and to get this > >>>>> process started. > >>>>>> > >>>>>> Thanks again, > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Monday, March 30, 2009 10:26 AM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC with a > >>>>> new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Tara, > >>>>>> > >>>>>> Nothing from Terry yet. I'll > >> keep bugging him. > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Monday, March 30, > >> 2009 9:23 AM > >>>>>> To: Davis, Bradley > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Brad, > >>>>>> Just wanted to check in and see > >>>>> if you were able to get the > >>>>>> information that you requested > >>>>>> from Terry yet? I would like > >>>>> to make sure you get the information > >>>>>> that you need to start on > >>>>>> the diffs before the > >> call this afternoon, so we can at least > >>>>>> say we have made progress on this > >>>>>> since the request for this came > >>>>> in two week's ago. > >>>>>> > >>>>>> Thanks, > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Friday, March 27, > >> 2009 4:06 PM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Tara, > >>>>>> > >>>>>> diffs are easy enough, I'll > >>>>> attach them to the defect. However, in > >>>>>> this case Motorola has provided two different files > >>>>>> entirely. The diff/patch will > >>>>> still work, but since the changes > >>>>>> were not made to our existing files, it's hard to sort out > >>>>>> exactly what was changed simply > >>>>> by lookinig at the diff. > >>>>>> > >>>>>> Still can't seem to get in > >>>>> touch with Terry. Perhaps he can shed > >>>>>> some light on this if we get him on the Monday call. > >>>>>> I'll include my comments with > >>>>> the diffs in the defect. > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Friday, March 27, > >> 2009 2:14 PM > >>>>>> To: Davis, Bradley > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Brad, > >>>>>> Will you be able to do the > >>>>> diffs that Bruce and Al requested or do > >>>>>> you need additional assistance with > >>>>>> that? I would like to at least > >>>>> have that done by the time we have > >>>>>> the meeting with Motorola on Monday > >>>>>> afternoon. If you need > >>>>> additional help, please let me know. > >>>>>> > >>>>>> Thank you, > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Davis, Bradley > >>>>>> Sent: Friday, March 27, > >> 2009 10:51 AM > >>>>>> To: Copos, Calin; Fahey, Tara > >>>>>> Cc: Koldoff, Arleen; > >> Coker, Bonnie > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi All, > >>>>>> > >>>>>> I've requested details from > >>>>> Terry but, no reply yet. I'll call him > >>>>>> as soon as I'm off the phone this morning. > >>>>>> > >>>>>> Brad > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Copos, Calin > >>>>>> Sent: Friday, March 27, > >> 2009 9:49 AM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen; Coker, > >>>>> Bonnie; Davis, Bradley > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Tara, > >>>>>> > >>>>>> If Brad owns this TSR then > >>>>> probably he was in contact with the > >>>>>> customer and his > >>>>>> info take precedence of > >> what I know. > >>>>>> > >>>>>> Here is what I know: Motorola > >>>>> uses two BSPs in their production > >>>>>> system, > >>>>>> Sun X4200 and Sun CP3020 both > >>>>> based on PNE 1.5 with an additional > >>>>>> layer > >>>>>> known by everyone as K21 which > >>>>> updates the kernel to 2.6.21.7 (a > >>>>>> pre-release > >>>>>> from WRL 2.0). > >>>>>> > >>>>>> Hope this answer part > >> of your question. > >>>>>> > >>>>>> Calin. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Friday, March 27, > >> 2009 11:32 AM > >>>>>> To: Copos, Calin > >>>>>> Cc: Koldoff, Arleen; Coker, > >>>>> Bonnie; Davis, Bradley > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Calin, > >>>>>> Bonnie is aware of the issue > >>>>> and a TSR and SPR have been opened on > >>>>>> the issue, as it was planned to be routed through > >>>>>> the Premium Support > >> channel as an > >>>> enhancement request, with the > >>>>>> understanding that we would > >>>>> be working > >>>>>> directly with > >>>>>> engineering. With that being > >>>>> said, I need to be asking Brad to do > >>>>>> the diffs since he is the owner of the TSR.... > >>>>>> > >>>>>> What we are hoping to find out > >>>>> is the WR Linux version that > >>>>>> Motorola is expecting these TIPC changes to be > >> incorporated into. > >>>>>> To be more specific, this is > >>>>> what we are looking for, summed up by > >>>>>> Bruce Ashfield and Allan Stephens: > >>>>>> > >>>>>> Stephens, Allan wrote: > >>>>>> > Hi there: > >>>>>> > >>>>>> Sorry for my slow reply, I'm > >>>>> out of the office this week. > >>>>>> > I'm unclear about what > >>>>> Motorola is requesting. Are they simply > >>>>>> asking > >>>>>> > for the patch to be > >>>>> incorporated into WR-Linux 1.4 (which is > >>>>>> what I > >>>>>> > assume they are using), or do > >>>>> they expect to also see it added > >>>>>> to > >>>>>> > WR-Linux 2.0, > >> WR-Linux 3.0, and > >>>> WR-Linux 3.1? Or do they want > >>>>>> us to > >>>>>> > add it into WR-Linux 3.1 only? > >>>>>> > > >>>>>> > In general, I would recommend > >>>>> against Wind River supporting > >>>>>> > non-standard TIPC patches. > >>>>> (We've had some not inconsiderable > >>>>>> grief > >>>>>> > with Nortel's non-standard > >>>>> patches in the past.) If Motorola > >>>>>> would > >>>>>> > like to see this functionality > >>>> incorporated into TIPC -- which > >>>>>> is an > >>>>>> > entirely reasonable desire -- > >>>>> the proper procedure is to submit > >>>>>> the > >>>>>> > patch to the open source TIPC > >>>>> project (which I chair) so it can > >>>>>> be > >>>>>> > properly integrated into the > >>>>> TIPC 1.7 code stream, and > >>>>>> eventually > >>>>>> > integrated into future > >>>>> releases of the Linux kernel, WR-Linux, > >>>>>> VxWorks, and so on. > >>>>>> > >>>>>> This is the proper > >> route for the patch. > >>>>>> Al hit it spot on. > >>>>>> This needs to go upstream and > >>>>> then loop back into wrlinux. > >>>>>> At the very least, it > >> needs to go > >>>> upstream at the same time we > >>>>>> look at the patch. > >>>>>> We have a policy of not carrying > >>>> specific patches unless > >>>>>> absolutely necessary. > >>>>>> We definitely need to know the > >>>>> targeted release, because the > >>>>>> procedures are different around them all. i.e. we won't > >>> be updating > >>>>>> tipc from the upstream project for old releases, but I can > >>>>> refresh the > >>>>>> tipc support for the releases later this year. > >>>>>> The changes weren't sent as > >>>>> patches, so I can't even easily tell > >>>>>> what release they are against. In order to do a proper > >>>>> review, someone > >>>>>> needs to send them as diffs against a supported Wind River > >>>>> release and > >>>>>> then it can go through our standard tech review and > gatekeeping > >>>>>> process. > >>>>>> > >>>>>> Bruce > >>>>>> > >>>>>> > > >>>>>> > That being said, I believe > >>>>> that Bruce is the gatekeeper who best > >>>>>> > understands the > >> policies and procedures for accepting this > >>>>>> kind of > >>>>>> > contribution into WR-Linux, > >>>>> so we really need to hear from him. > >>>>>> > > >>>>>> > Regards, > >>>>>> > Al > >>>>>> > >>>>>> So if you can provide the WR > >>>>> Linux version, it would be greatly > >>>>>> appreciated. > >>>>>> > >>>>>> Brad - Can you please take > >>>>> Motorola's TIPC changes that they > >>>>>> provided and do the diffs > >>>>>> that was requested? > >>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Tara > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Copos, Calin > >>>>>> Sent: Friday, March 27, > >> 2009 9:49 AM > >>>>>> To: Fahey, Tara > >>>>>> Cc: Koldoff, Arleen; Coker, > >>>>> Bonnie; ma...@mo... > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Tara, > >>>>>> > >>>>>> I did help one of the Motorola > >>>>> engineers (Carlos Bejar-Colonia, > >>>>>> car...@mo...) in > >>>>> his recent attempt to build and > >>>>>> test TIPC-1.7.6 (their > >> platform includes > >>>>>> TICP-1.5.12) but I am > >>>>>> not aware of the attached patch. > >>>>>> > >>>>>> Nevertheless, if you and Bonnie > >>>>> agree of this issue, I can bring > >>>>>> this issues to resolution (find > >>>>> who from Motorola is responsible > >>>>>> for the changes, bring the > >>>>> changes to the patch format and > >>>>>> prepare the patch for the > >>>>> engineering release). > >>>>>> > >>>>>> Thanks, > >>>>>> > >>>>>> Calin. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Friday, March 27, > >> 2009 10:27 AM > >>>>>> To: Copos, Calin > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: FW: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Hi Calin, > >>>>>> I am looking to get some > >>>>> information from you in regards to the > >>>>>> TIPC changes that Motorola provided to > >>>>>> us that they would like > >> to see incorporated into the standard > >>>>>> WR Linux product. > >>>>>> > >>>>>> Mansour stated that they would > >>>>> like to have it incorporated into > >>>>>> the package that they use today and > >>>>>> that I can get all the > >>>>> information on what that is from you. > >>>>>> > >>>>>> Could you please provide those > >>>>> details to me, so that I can in > >>>>>> turn start the process for this to get routed > >>>>>> properly to engineering. > >>>>>> > >>>>>> Bruce Ashfield also stated that > >>>>> the changes that Motorola would > >>>>>> like to see incorporated, which I have > >>>>>> attached to this email weren't > >>>>> in patch form and that they needed > >>>>>> to be sent as diffs against a standard WR > >>>>>> release, to go through the > >>>>> standard tech review and gatekeeping > >>>>>> process. Since I am unsure who can > >>>>>> do that - could you please > >>>>> point me in the right direction on who > >>>>>> can address that issue? > >>>>>> > >>>>>> Thanks, > >>>>>> Tara Fahey > >>>>>> > >>>>>> Tara Fahey, Enterprise Support > >>>>> Manager, Wind River > >>>>>> office 630.971.6227 mobile > >>>>> 630.809.6393 fax 630.971.5901 > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> Sent: Friday, March 27, > >> 2009 9:09 AM > >>>>>> To: Bagherzadeh > >> Mansour-MGIA0439; > >>>> Bejar-Colonia Carlos-W00154; > >>>>>> Medina Oscar-MGIF1243 > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Mansour, > >>>>>> Thank you for the info - I will > >>>>> get in touch with Calin to get the > >>>>>> information necessary > >>>>>> to move this along. > >>>>>> > >>>>>> Thanks again and have a great > >>>>> weekend and talk with you all on > >>>>>> Monday! > >>>>>> Tara > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Bagherzadeh > >>>>> Mansour-MGIA0439 [mailto:ma...@mo...] > >>>>>> Sent: Friday, March 27, > >> 2009 7:44 AM > >>>>>> To: Fahey, Tara; > >> Bejar-Colonia Carlos-W00154; Medina > >>>>>> Oscar-MGIF1243 > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: RE: WR to support TIPC > >>>>> with a new patch delivered by > >>>>>> Motorola (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Tara, > >>>>>> We would like this patch to be > >>>>> part of today's package that we use > >>>>>> . Calin has all the info you need regarding our package > >>>>>> tx > >>>>>> Mansour > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> From: Fahey, Tara > >>>>>> [mailto:Tar...@wi...] > >>>>>> Sent: Thursday, March > >> 26, 2009 6:12 PM > >>>>>> To: Bagherzadeh > >> Mansour-MGIA0439; > >>>> Bejar-Colonia Carlos-W00154; > >>>>>> Medina Oscar-MGIF1243 > >>>>>> Cc: Koldoff, Arleen > >>>>>> Subject: WR to support TIPC > >>>>> with a new patch delivered by Motorola > >>>>>> (TSR 735464/SPR WIND00160708) > >>>>>> > >>>>>> > >>>>>> Good Evening Gentlemen, > >>>>>> I am following up in regards to > >>>>> the TIPC patch that was provided > >>>>>> by Motorola, as we still need to know your expectations > >>> of what WR > >>>>>> Linux version you > >>>>>> would like to see this > >> patch be incorporated into, before we > >>>>>> can escalate and route this > >>>>> properly to > >>>>>> our engineering team. > >>>>>> > >>>>>> If anyone could please provide > >>>>> me with this information, it would > >>>>>> be greatly appreciated. > >>>>>> > >>>>>> If you have any questions, > >>>>> please feel free to contact me. > >>>>>> > >>>>>> Thank you, > >>>>>> > >>>>>> Tara Fahey, Enterprise Support > >>>>> Manager, Wind River > >>>>>> office 630.971.6227 mobile > >>>>> 630.809.6393 fax 630.971.5901 > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>> > > |
