hi,
I've been able to get tinyxml to crash with an unknown/invalid entity (patch below). One other thing though, tinyxml converts entities in xml comments. According to the xml spec, entities are to be left as is in comments.
basic
--- tinyxmlparser.cpp
+++ tinyxmlparser.cpp
@@ -618,7 +618,8 @@
}
}
}
- return p + strlen( endTag );
+ if (p) p += strlen( endTag );
+ return p;
}
#ifdef TIXML_USE_STL
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
hi,
I've been able to get tinyxml to crash with an unknown/invalid entity (patch below). One other thing though, tinyxml converts entities in xml comments. According to the xml spec, entities are to be left as is in comments.
basic
--- tinyxmlparser.cpp
+++ tinyxmlparser.cpp
@@ -618,7 +618,8 @@
}
}
}
- return p + strlen( endTag );
+ if (p) p += strlen( endTag );
+ return p;
}
#ifdef TIXML_USE_STL
Thanks for the bugs! The crash is fixed (although not yet checked in) and I filed a bug on the entities in comments.