Menu

unknown/invalid entity causes a crash

Developer
basic
2006-04-19
2013-05-20
  • basic

    basic - 2006-04-19

    hi,
      I've been able to get tinyxml to crash with an unknown/invalid entity (patch below). One other thing though, tinyxml converts entities in xml comments. According to the xml spec, entities are to be left as is in comments.

    basic

    --- tinyxmlparser.cpp
    +++ tinyxmlparser.cpp
    @@ -618,7 +618,8 @@
                 }
             }
         }
    -    return p + strlen( endTag );
    +    if (p) p += strlen( endTag );
    +    return p;
    }

    #ifdef TIXML_USE_STL

     
    • Lee Thomason

      Lee Thomason - 2006-04-23

      Thanks for the bugs! The crash is fixed (although not yet checked in) and I filed a bug on the entities in comments.

       

Log in to post a comment.