We compile all of our code using the following warnings turned on:
-Wformat -Wno-format-y2k -Wcomment -Wmissing-braces -Wparentheses -Wreturn-type -Wswitch -Wtrigraphs -Wunused -Wunknown-pragmas -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wconversion -Wsign-compare -Wcast-qual -Wcast-align -Wunused -Wswitch-enum -Wundef -Wextra -Wctor-dtor-privacy -Weffc++ -Wall
We get quite a few warnings about TinyXml, mainly due to initializer lists not being defined. We compile all of the TinyXml into a library and include that in our software. Because the header files include implementation, we get warnings from TinyXml for every executable that utilizes the library. I went through the source and fixed all of these initializers. How would I go about submitting this to the project?
I realize not everyone runs with those warnings on, but they have been useful in isolating issues due to lack of initializers (not initting variables correctly), copy constructor and operator= issues.
Log in to post a comment.