Hi, I just built tinyxml with gcc version 4.5.2, using the -Weffc++ flag. The flag reports a lot warnings based on not using initialiser lists in constructors, (which I'm not so fussed about), but among the noise it reported that on line 1645 of tinyxml.h :
TiXmlHandleoperator=(constTiXmlHandle&ref)
Was missing the '&' in the return type. It probably isn't effecting code quality much, but I thought I might just point it out. Was it intentional?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi, I just built tinyxml with gcc version 4.5.2, using the -Weffc++ flag. The flag reports a lot warnings based on not using initialiser lists in constructors, (which I'm not so fussed about), but among the noise it reported that on line 1645 of tinyxml.h :
Was missing the '&' in the return type. It probably isn't effecting code quality much, but I thought I might just point it out. Was it intentional?