Thread: [Tinyx-devel] [PATCH] LIBC: Change libc include.
Status: Planning
Brought to you by:
davidcohen
From: David C. <da...@gm...> - 2008-01-11 03:02:36
|
Adding include/libc to standard include's path Fixing new libc include path on device.c Signed-off-by: David Cohen <da...@gm...> --- Makefile | 2 +- kernel/device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 0ca9772..3b0a471 100644 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy OBJDUMP = $(CROSS_COMPILE)objdump AWK = awk CFLAGS = -Wall -Os -mcpu=arm7tdmi -INCLUDES = -Iinclude +INCLUDES = -Iinclude -Iinclude/libc PYTHON = python diff --git a/kernel/device.c b/kernel/device.c index 44374ab..8cd35ba 100644 --- a/kernel/device.c +++ b/kernel/device.c @@ -21,7 +21,7 @@ #include <tinyx/device.h> #include <tinyx/list.h> -#include <tinyx/libc/string.h> +#include <string.h> DECLARE_LIST_HEAD(bus_list); DECLARE_LIST_HEAD(driver_list); -- 1.5.3.7 |
From: David C. <da...@gm...> - 2008-01-13 00:32:18
|
Adding include/libc to standard include's path Fixing new libc include path on device.c Signed-off-by: David Cohen <da...@gm...> --- Makefile | 2 +- kernel/device.c | 2 +- lib/libc/strerror.c | 2 +- lib/libc/string.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 0ca9772..3b0a471 100644 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy OBJDUMP = $(CROSS_COMPILE)objdump AWK = awk CFLAGS = -Wall -Os -mcpu=arm7tdmi -INCLUDES = -Iinclude +INCLUDES = -Iinclude -Iinclude/libc PYTHON = python diff --git a/kernel/device.c b/kernel/device.c index 44374ab..8cd35ba 100644 --- a/kernel/device.c +++ b/kernel/device.c @@ -21,7 +21,7 @@ #include <tinyx/device.h> #include <tinyx/list.h> -#include <tinyx/libc/string.h> +#include <string.h> DECLARE_LIST_HEAD(bus_list); DECLARE_LIST_HEAD(driver_list); diff --git a/lib/libc/strerror.c b/lib/libc/strerror.c index cd189a8..ceeb466 100644 --- a/lib/libc/strerror.c +++ b/lib/libc/strerror.c @@ -19,7 +19,7 @@ * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. */ -#include <libc/string.h> +#include <string.h> #include <tinyx/errno.h> #ifdef DEBUG diff --git a/lib/libc/string.c b/lib/libc/string.c index 1a26851..3f738fb 100644 --- a/lib/libc/string.c +++ b/lib/libc/string.c @@ -19,7 +19,7 @@ * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. */ -#include <libc/string.h> +#include <string.h> /** * memset - Fill a memory region with data -- 1.5.3.7 |
From: David C. <da...@gm...> - 2008-01-13 00:33:44
|
Hi, So, this is how to use libc headers. Like on standard C, without any extra path. I'll push it now as it is simple and urgent, in order to not break any new patch. Br, David On Jan 12, 2008 8:30 PM, David Cohen <da...@gm...> wrote: > Adding include/libc to standard include's path > Fixing new libc include path on device.c > > Signed-off-by: David Cohen <da...@gm...> > --- > Makefile | 2 +- > kernel/device.c | 2 +- > lib/libc/strerror.c | 2 +- > lib/libc/string.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index 0ca9772..3b0a471 100644 > --- a/Makefile > +++ b/Makefile > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > OBJDUMP = $(CROSS_COMPILE)objdump > AWK = awk > CFLAGS = -Wall -Os -mcpu=arm7tdmi > -INCLUDES = -Iinclude > +INCLUDES = -Iinclude -Iinclude/libc > > PYTHON = python > > diff --git a/kernel/device.c b/kernel/device.c > index 44374ab..8cd35ba 100644 > --- a/kernel/device.c > +++ b/kernel/device.c > @@ -21,7 +21,7 @@ > > #include <tinyx/device.h> > #include <tinyx/list.h> > -#include <tinyx/libc/string.h> > +#include <string.h> > > DECLARE_LIST_HEAD(bus_list); > DECLARE_LIST_HEAD(driver_list); > diff --git a/lib/libc/strerror.c b/lib/libc/strerror.c > index cd189a8..ceeb466 100644 > --- a/lib/libc/strerror.c > +++ b/lib/libc/strerror.c > @@ -19,7 +19,7 @@ > * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. > */ > > -#include <libc/string.h> > +#include <string.h> > #include <tinyx/errno.h> > > #ifdef DEBUG > diff --git a/lib/libc/string.c b/lib/libc/string.c > index 1a26851..3f738fb 100644 > --- a/lib/libc/string.c > +++ b/lib/libc/string.c > @@ -19,7 +19,7 @@ > * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. > */ > > -#include <libc/string.h> > +#include <string.h> > > /** > * memset - Fill a memory region with data > -- > 1.5.3.7 > > -- David Cohen Instituto Nokia de Tecnologia - INdT Manaus - Brazil |
From: David C. <da...@gm...> - 2008-01-11 03:03:47
|
This is the other way for libc include's path. Any comments? Briglia? Balbi? Br, David Cohen On Jan 10, 2008 11:02 PM, David Cohen <da...@gm...> wrote: > Adding include/libc to standard include's path > Fixing new libc include path on device.c > > Signed-off-by: David Cohen <da...@gm...> > --- > Makefile | 2 +- > kernel/device.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 0ca9772..3b0a471 100644 > --- a/Makefile > +++ b/Makefile > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > OBJDUMP = $(CROSS_COMPILE)objdump > AWK = awk > CFLAGS = -Wall -Os -mcpu=arm7tdmi > -INCLUDES = -Iinclude > +INCLUDES = -Iinclude -Iinclude/libc > > PYTHON = python > > diff --git a/kernel/device.c b/kernel/device.c > index 44374ab..8cd35ba 100644 > --- a/kernel/device.c > +++ b/kernel/device.c > @@ -21,7 +21,7 @@ > > #include <tinyx/device.h> > #include <tinyx/list.h> > -#include <tinyx/libc/string.h> > +#include <string.h> > > DECLARE_LIST_HEAD(bus_list); > DECLARE_LIST_HEAD(driver_list); > -- > 1.5.3.7 > > -- David Cohen Instituto Nokia de Tecnologia - INdT Manaus - Brazil |
From: Anderson B. <and...@br...> - 2008-01-11 03:39:11
|
On 1/10/08, David Cohen <da...@gm...> wrote: > > This is the other way for libc include's path. > > Any comments? Briglia? Balbi? IMHO, this way is the default, right? I still didn't see differents include's paths due to different archs on linux kernel. BR, Anderson Briglia Br, > > David Cohen > > On Jan 10, 2008 11:02 PM, David Cohen <da...@gm...> wrote: > > Adding include/libc to standard include's path > > Fixing new libc include path on device.c > > > > Signed-off-by: David Cohen <da...@gm...> > > --- > > Makefile | 2 +- > > kernel/device.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 0ca9772..3b0a471 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > > OBJDUMP = $(CROSS_COMPILE)objdump > > AWK = awk > > CFLAGS = -Wall -Os -mcpu=arm7tdmi > > -INCLUDES = -Iinclude > > +INCLUDES = -Iinclude -Iinclude/libc > > > > PYTHON = python > > > > diff --git a/kernel/device.c b/kernel/device.c > > index 44374ab..8cd35ba 100644 > > --- a/kernel/device.c > > +++ b/kernel/device.c > > @@ -21,7 +21,7 @@ > > > > #include <tinyx/device.h> > > #include <tinyx/list.h> > > -#include <tinyx/libc/string.h> > > +#include <string.h> > > > > DECLARE_LIST_HEAD(bus_list); > > DECLARE_LIST_HEAD(driver_list); > > -- > > 1.5.3.7 > > > > > > > > -- > David Cohen > Instituto Nokia de Tecnologia - INdT > Manaus - Brazil > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Tinyx-devel mailing list > Tin...@li... > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > |
From: David C. <da...@gm...> - 2008-01-11 03:43:16
|
Hi, On Jan 10, 2008 11:39 PM, Anderson Briglia <and...@br...> wrote: > On 1/10/08, David Cohen <da...@gm...> wrote: > > > This is the other way for libc include's path. > > > > Any comments? Briglia? Balbi? > > IMHO, this way is the default, right? I still didn't see differents > include's paths due to different archs on linux kernel. You're right, but the arch's path is transparent. The two choices are: <libc/string.h> or <string.h> Which one is better? Regards, David > > BR, > > Anderson Briglia > > > > > > > > > Br, > > > > David Cohen > > > > On Jan 10, 2008 11:02 PM, David Cohen < da...@gm...> wrote: > > > Adding include/libc to standard include's path > > > Fixing new libc include path on device.c > > > > > > Signed-off-by: David Cohen < da...@gm...> > > > --- > > > Makefile | 2 +- > > > kernel/device.c | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Makefile b/Makefile > > > index 0ca9772..3b0a471 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > > > OBJDUMP = $(CROSS_COMPILE)objdump > > > AWK = awk > > > CFLAGS = -Wall -Os -mcpu=arm7tdmi > > > -INCLUDES = -Iinclude > > > +INCLUDES = -Iinclude -Iinclude/libc > > > > > > PYTHON = python > > > > > > diff --git a/kernel/device.c b/kernel/device.c > > > index 44374ab..8cd35ba 100644 > > > --- a/kernel/device.c > > > +++ b/kernel/device.c > > > @@ -21,7 +21,7 @@ > > > > > > #include <tinyx/device.h> > > > #include <tinyx/list.h> > > > -#include <tinyx/libc/string.h> > > > +#include <string.h > > > > > > > DECLARE_LIST_HEAD(bus_list); > > > DECLARE_LIST_HEAD(driver_list); > > > -- > > > 1.5.3.7 > > > > > > > > > > > > > > -- > > David Cohen > > Instituto Nokia de Tecnologia - INdT > > Manaus - Brazil > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > _______________________________________________ > > Tinyx-devel mailing list > > Tin...@li... > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > > > |
From: David C. <da...@gm...> - 2008-01-12 16:58:27
|
Hi all, We have to decide it. Which one is better choice: <libc/string.h> or <string.h>? Br, David On Jan 10, 2008 11:43 PM, David Cohen <da...@gm...> wrote: > Hi, > > On Jan 10, 2008 11:39 PM, Anderson Briglia <and...@br...> wrote: > > On 1/10/08, David Cohen <da...@gm...> wrote: > > > > > This is the other way for libc include's path. > > > > > > Any comments? Briglia? Balbi? > > > > IMHO, this way is the default, right? I still didn't see differents > > include's paths due to different archs on linux kernel. > > You're right, but the arch's path is transparent. The two choices are: > <libc/string.h> or <string.h> > > Which one is better? > > Regards, > > David > > > > > > BR, > > > > Anderson Briglia > > > > > > > > > > > > > > Br, > > > > > > David Cohen > > > > > > On Jan 10, 2008 11:02 PM, David Cohen < da...@gm...> wrote: > > > > Adding include/libc to standard include's path > > > > Fixing new libc include path on device.c > > > > > > > > Signed-off-by: David Cohen < da...@gm...> > > > > --- > > > > Makefile | 2 +- > > > > kernel/device.c | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Makefile b/Makefile > > > > index 0ca9772..3b0a471 100644 > > > > --- a/Makefile > > > > +++ b/Makefile > > > > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > > > > OBJDUMP = $(CROSS_COMPILE)objdump > > > > AWK = awk > > > > CFLAGS = -Wall -Os -mcpu=arm7tdmi > > > > -INCLUDES = -Iinclude > > > > +INCLUDES = -Iinclude -Iinclude/libc > > > > > > > > PYTHON = python > > > > > > > > diff --git a/kernel/device.c b/kernel/device.c > > > > index 44374ab..8cd35ba 100644 > > > > --- a/kernel/device.c > > > > +++ b/kernel/device.c > > > > @@ -21,7 +21,7 @@ > > > > > > > > #include <tinyx/device.h> > > > > #include <tinyx/list.h> > > > > -#include <tinyx/libc/string.h> > > > > +#include <string.h > > > > > > > > > DECLARE_LIST_HEAD(bus_list); > > > > DECLARE_LIST_HEAD(driver_list); > > > > -- > > > > 1.5.3.7 > > > > > > > > > > > > > > > > > > > > -- > > > David Cohen > > > Instituto Nokia de Tecnologia - INdT > > > Manaus - Brazil > > > > > > ------------------------------------------------------------------------- > > > Check out the new SourceForge.net Marketplace. > > > It's the best place to buy or sell services for > > > just about anything Open Source. > > > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > > _______________________________________________ > > > Tinyx-devel mailing list > > > Tin...@li... > > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > > > > > > > -- David Cohen Instituto Nokia de Tecnologia - INdT Manaus - Brazil |
From: Felipe B. <me...@fe...> - 2008-01-12 17:54:53
|
On Sat, Jan 12, 2008 at 12:58:31PM -0400, David Cohen wrote: > Hi all, > > We have to decide it. > Which one is better choice: > <libc/string.h> or <string.h>? <string.h> but you should change all the users of it in your patch > > Br, > > David > > On Jan 10, 2008 11:43 PM, David Cohen <da...@gm...> wrote: > > Hi, > > > > On Jan 10, 2008 11:39 PM, Anderson Briglia <and...@br...> wrote: > > > On 1/10/08, David Cohen <da...@gm...> wrote: > > > > > > > This is the other way for libc include's path. > > > > > > > > Any comments? Briglia? Balbi? > > > > > > IMHO, this way is the default, right? I still didn't see differents > > > include's paths due to different archs on linux kernel. > > > > You're right, but the arch's path is transparent. The two choices are: > > <libc/string.h> or <string.h> > > > > Which one is better? > > > > Regards, > > > > David > > > > > > > > > > BR, > > > > > > Anderson Briglia > > > > > > > > > > > > > > > > > > > Br, > > > > > > > > David Cohen > > > > > > > > On Jan 10, 2008 11:02 PM, David Cohen < da...@gm...> wrote: > > > > > Adding include/libc to standard include's path > > > > > Fixing new libc include path on device.c > > > > > > > > > > Signed-off-by: David Cohen < da...@gm...> > > > > > --- > > > > > Makefile | 2 +- > > > > > kernel/device.c | 2 +- > > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > index 0ca9772..3b0a471 100644 > > > > > --- a/Makefile > > > > > +++ b/Makefile > > > > > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > > > > > OBJDUMP = $(CROSS_COMPILE)objdump > > > > > AWK = awk > > > > > CFLAGS = -Wall -Os -mcpu=arm7tdmi > > > > > -INCLUDES = -Iinclude > > > > > +INCLUDES = -Iinclude -Iinclude/libc > > > > > > > > > > PYTHON = python > > > > > > > > > > diff --git a/kernel/device.c b/kernel/device.c > > > > > index 44374ab..8cd35ba 100644 > > > > > --- a/kernel/device.c > > > > > +++ b/kernel/device.c > > > > > @@ -21,7 +21,7 @@ > > > > > > > > > > #include <tinyx/device.h> > > > > > #include <tinyx/list.h> > > > > > -#include <tinyx/libc/string.h> > > > > > +#include <string.h > > > > > > > > > > > DECLARE_LIST_HEAD(bus_list); > > > > > DECLARE_LIST_HEAD(driver_list); > > > > > -- > > > > > 1.5.3.7 > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > David Cohen > > > > Instituto Nokia de Tecnologia - INdT > > > > Manaus - Brazil > > > > > > > > ------------------------------------------------------------------------- > > > > Check out the new SourceForge.net Marketplace. > > > > It's the best place to buy or sell services for > > > > just about anything Open Source. > > > > > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > > > _______________________________________________ > > > > Tinyx-devel mailing list > > > > Tin...@li... > > > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > > > > > > > > > > > > > > > -- > David Cohen > Instituto Nokia de Tecnologia - INdT > Manaus - Brazil > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Tinyx-devel mailing list > Tin...@li... > https://lists.sourceforge.net/lists/listinfo/tinyx-devel -- Best Regards, Felipe Balbi me...@fe... http://blog.felipebalbi.com |
From: David C. <da...@gm...> - 2008-01-12 20:12:37
|
Hi, On 1/12/08, Felipe Balbi <me...@fe...> wrote: > On Sat, Jan 12, 2008 at 12:58:31PM -0400, David Cohen wrote: > > Hi all, > > > > We have to decide it. > > Which one is better choice: > > <libc/string.h> or <string.h>? > > <string.h> > > but you should change all the users of it in your patch > So, I will do it. Br, David > > > > Br, > > > > David > > > > On Jan 10, 2008 11:43 PM, David Cohen <da...@gm...> wrote: > > > Hi, > > > > > > On Jan 10, 2008 11:39 PM, Anderson Briglia <and...@br...> wrote: > > > > On 1/10/08, David Cohen <da...@gm...> wrote: > > > > > > > > > This is the other way for libc include's path. > > > > > > > > > > Any comments? Briglia? Balbi? > > > > > > > > IMHO, this way is the default, right? I still didn't see differents > > > > include's paths due to different archs on linux kernel. > > > > > > You're right, but the arch's path is transparent. The two choices are: > > > <libc/string.h> or <string.h> > > > > > > Which one is better? > > > > > > Regards, > > > > > > David > > > > > > > > > > > > > > BR, > > > > > > > > Anderson Briglia > > > > > > > > > > > > > > > > > > > > > > > > Br, > > > > > > > > > > David Cohen > > > > > > > > > > On Jan 10, 2008 11:02 PM, David Cohen < da...@gm...> wrote: > > > > > > Adding include/libc to standard include's path > > > > > > Fixing new libc include path on device.c > > > > > > > > > > > > Signed-off-by: David Cohen < da...@gm...> > > > > > > --- > > > > > > Makefile | 2 +- > > > > > > kernel/device.c | 2 +- > > > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > > index 0ca9772..3b0a471 100644 > > > > > > --- a/Makefile > > > > > > +++ b/Makefile > > > > > > @@ -20,7 +20,7 @@ OBJCOPY = $(CROSS_COMPILE)objcopy > > > > > > OBJDUMP = $(CROSS_COMPILE)objdump > > > > > > AWK = awk > > > > > > CFLAGS = -Wall -Os -mcpu=arm7tdmi > > > > > > -INCLUDES = -Iinclude > > > > > > +INCLUDES = -Iinclude -Iinclude/libc > > > > > > > > > > > > PYTHON = python > > > > > > > > > > > > diff --git a/kernel/device.c b/kernel/device.c > > > > > > index 44374ab..8cd35ba 100644 > > > > > > --- a/kernel/device.c > > > > > > +++ b/kernel/device.c > > > > > > @@ -21,7 +21,7 @@ > > > > > > > > > > > > #include <tinyx/device.h> > > > > > > #include <tinyx/list.h> > > > > > > -#include <tinyx/libc/string.h> > > > > > > +#include <string.h > > > > > > > > > > > > > DECLARE_LIST_HEAD(bus_list); > > > > > > DECLARE_LIST_HEAD(driver_list); > > > > > > -- > > > > > > 1.5.3.7 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > David Cohen > > > > > Instituto Nokia de Tecnologia - INdT > > > > > Manaus - Brazil > > > > > > > > > > ------------------------------------------------------------------------- > > > > > Check out the new SourceForge.net Marketplace. > > > > > It's the best place to buy or sell services for > > > > > just about anything Open Source. > > > > > > > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > > > > _______________________________________________ > > > > > Tinyx-devel mailing list > > > > > Tin...@li... > > > > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > > > > > > > > > > > > > > > > > > > > > > > -- > > David Cohen > > Instituto Nokia de Tecnologia - INdT > > Manaus - Brazil > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > _______________________________________________ > > Tinyx-devel mailing list > > Tin...@li... > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > -- > Best Regards, > > Felipe Balbi > me...@fe... > http://blog.felipebalbi.com > |