Re: [Tinyx-devel] [PATCH 1/2] LIBC: Move libc headers outside tinyx directory
Status: Planning
Brought to you by:
davidcohen
Menu
▾
▴
Re: [Tinyx-devel] [PATCH 1/2] LIBC: Move libc headers outside tinyx directory
|
From: David C. <da...@gm...> - 2008-01-08 20:40:21
|
Hi, On Jan 8, 2008 1:47 PM, Felipe Balbi <me...@fe...> wrote: > On Tue, Jan 08, 2008 at 01:23:48PM -0400, David Cohen wrote: > > I agree with this change. But "include/libc" should be added to the > > default include PATH. So, we can include <string.h>, instead of > > <libc/string.h>. > > Good catch. Can you do it, or should I send a patch ?? > > > btw, I was thinking on trying to use kbuild as our build system. It's a > debian package and we can embed it on tinyx and use it to, for example, > make config tinyx. This way we would be able, for example, to choose > which parts of libc we want to build this "version" of tinyx with. > Remember tinyx will be used on arm7 and another really "resource-less" > systems and printf (for instance) would be useful only on debugging > builds, also, depending on the use of tinyx, we won't need strcoll, > strcmp, strcpy, etc. > > What do you think ?? I agree. But it's better to not make dependences from tinyx to any system's lib. We can put kbuild on Tinyx just basing on kbuild from Debian, but not using the Debina's lib. Regards, David > > > > > > Br, > > > > David > > > > On Jan 8, 2008 12:52 PM, Felipe Balbi <me...@fe...> wrote: > > > Cosmetic. No functional changes. > > > > > > Signed-off-by: Felipe Balbi <me...@fe...> > > > --- > > > include/libc/string.h | 27 +++++++++++++++++++++++++++ > > > include/tinyx/libc/string.h | 27 --------------------------- > > > lib/libc/string.c | 2 +- > > > 3 files changed, 28 insertions(+), 28 deletions(-) > > > create mode 100644 include/libc/string.h > > > delete mode 100644 include/tinyx/libc/string.h > > > > > > diff --git a/include/libc/string.h b/include/libc/string.h > > > new file mode 100644 > > > index 0000000..8815a86 > > > --- /dev/null > > > +++ b/include/libc/string.h > > > @@ -0,0 +1,27 @@ > > > +/* include/libc/string.h > > > + * > > > + * Copyright (C) 2007 David Cohen <da...@gm...> > > > + * Copyright (C) 2007 Felipe Balbi <me...@fe...> > > > + * > > > + * This file is part of Tinyx Nanokernel Project. > > > + * > > > + * Tinyx is free software: you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License as published by > > > + * the Free Software Foundation, either version 3 of the License, or > > > + * (at your option) any later version. > > > + * > > > + * Tinyx is distributed in the hope that it will be useful, > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > + * GNU General Public License for more details. > > > + * > > > + * You should have received a copy of the GNU General Public License > > > + * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. > > > + */ > > > + > > > +#ifndef __TINYX_LIBC_STRING_H > > > +#define __TINYX_LIBC_STRING_H > > > + > > > +int strcmp(const char *str1, const char *str2); > > > + > > > +#endif /* __TINYX_LIBC_STRING_H */ > > > diff --git a/include/tinyx/libc/string.h b/include/tinyx/libc/string.h > > > deleted file mode 100644 > > > index 4ff2b08..0000000 > > > --- a/include/tinyx/libc/string.h > > > +++ /dev/null > > > @@ -1,27 +0,0 @@ > > > -/* include/tinyx/libc/string.h > > > - * > > > - * Copyright (C) 2007 David Cohen <da...@gm...> > > > - * Copyright (C) 2007 Felipe Balbi <me...@fe...> > > > - * > > > - * This file is part of Tinyx Nanokernel Project. > > > - * > > > - * Tinyx is free software: you can redistribute it and/or modify > > > - * it under the terms of the GNU General Public License as published by > > > - * the Free Software Foundation, either version 3 of the License, or > > > - * (at your option) any later version. > > > - * > > > - * Tinyx is distributed in the hope that it will be useful, > > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > - * GNU General Public License for more details. > > > - * > > > - * You should have received a copy of the GNU General Public License > > > - * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. > > > - */ > > > - > > > -#ifndef __TINYX_LIBC_STRING_H > > > -#define __TINYX_LIBC_STRING_H > > > - > > > -int strcmp(const char *str1, const char *str2); > > > - > > > -#endif /* __TINYX_LIBC_STRING_H */ > > > diff --git a/lib/libc/string.c b/lib/libc/string.c > > > index 11c651b..d2e41a0 100644 > > > --- a/lib/libc/string.c > > > +++ b/lib/libc/string.c > > > @@ -19,7 +19,7 @@ > > > * along with Tinyx. If not, see <http://www.gnu.org/licenses/>. > > > */ > > > > > > -#include <tinyx/libc/string.h> > > > +#include <libc/string.h> > > > > > > int strcmp(const char *str1, const char *str2) > > > { > > > -- > > > 1.5.4.rc1.21.g0e545-dirty > > > > > > > > > ------------------------------------------------------------------------- > > > Check out the new SourceForge.net Marketplace. > > > It's the best place to buy or sell services for > > > just about anything Open Source. > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > > _______________________________________________ > > > Tinyx-devel mailing list > > > Tin...@li... > > > https://lists.sourceforge.net/lists/listinfo/tinyx-devel > > > > > > > > > > > -- > > David Cohen > > Instituto Nokia de Tecnologia - INdT > > Manaus - Brazil > > -- > Best Regards, > > Felipe Balbi > me...@fe... > http://blog.felipebalbi.com > -- David Cohen Instituto Nokia de Tecnologia - INdT Manaus - Brazil |
