Re: [Tinyx-devel] [PATCH] CLOCK: Never use extern in this project since

[David C. <da...@gm...>]

Hi,

On Jan 8, 2008 2:07 PM, Felipe Balbi <me...@fe...> wrote:
> Neve use extern here since we're always building
> a single binary to flash on a device. There are no
> modules at all.
>
> Signed-off-by: Felipe Balbi <me...@fe...>
> ---
>  arch/arm7/mach-lpc21xx/clock.h |    6 +++---
>  include/asm-generic/clock.h    |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm7/mach-lpc21xx/clock.h b/arch/arm7/mach-lpc21xx/clock.h
> index 214fd62..17ab17b 100644
> --- a/arch/arm7/mach-lpc21xx/clock.h
> +++ b/arch/arm7/mach-lpc21xx/clock.h
> @@ -25,8 +25,8 @@
>  #include <asm/arch-lpc2xxx/clock.h>
>  #include <tinyx/kernel.h>
>
> -extern unsigned int cclk_set_rate(struct clock *clk, unsigned int rate);
> -extern unsigned int pclk_set_rate(struct clock *clk, unsigned int rate);
> -extern void pclk_propagate(struct clock *clk, struct clock *parent);
> +unsigned int cclk_set_rate(struct clock *clk, unsigned int rate);
> +unsigned int pclk_set_rate(struct clock *clk, unsigned int rate);
> +void pclk_propagate(struct clock *clk, struct clock *parent);

These functions are static also.

Br,

David

>
>  #endif /* __ARCH_MACH_LPC2XXX_CLOCK_H */
> diff --git a/include/asm-generic/clock.h b/include/asm-generic/clock.h
> index 4ac8e7c..28561ea 100644
> --- a/include/asm-generic/clock.h
> +++ b/include/asm-generic/clock.h
> @@ -34,8 +34,8 @@ struct clock {
>
>  #define clk_get_rate(clk) (clk)->rate
>
> -extern void clk_set_list(struct clock *list, unsigned int num);
> -extern void clk_propagate(struct clock *clk, struct clock *parent);
> -extern unsigned int clk_set_rate(struct clock *clk, unsigned int rate);
> +void clk_set_list(struct clock *list, unsigned int num);
> +void clk_propagate(struct clock *clk, struct clock *parent);
> +unsigned int clk_set_rate(struct clock *clk, unsigned int rate);
>
>  #endif /* __ASM_GENERIC_CLOCK_H */
> --
> 1.5.3.7.1157.gbf82a
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Tinyx-devel mailing list
> Tin...@li...
> https://lists.sourceforge.net/lists/listinfo/tinyx-devel
>



-- 
David Cohen
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil