Re: [Tinyx-devel] [PATCH 1/2] LIBC: Move libc headers outside tinyx directory

[David C. <da...@gm...>]

I agree with this change. But "include/libc" should be added to the
default include PATH. So, we can include <string.h>, instead of
<libc/string.h>.

Br,

David

On Jan 8, 2008 12:52 PM, Felipe Balbi <me...@fe...> wrote:
> Cosmetic. No functional changes.
>
> Signed-off-by: Felipe Balbi <me...@fe...>
> ---
>  include/libc/string.h       |   27 +++++++++++++++++++++++++++
>  include/tinyx/libc/string.h |   27 ---------------------------
>  lib/libc/string.c           |    2 +-
>  3 files changed, 28 insertions(+), 28 deletions(-)
>  create mode 100644 include/libc/string.h
>  delete mode 100644 include/tinyx/libc/string.h
>
> diff --git a/include/libc/string.h b/include/libc/string.h
> new file mode 100644
> index 0000000..8815a86
> --- /dev/null
> +++ b/include/libc/string.h
> @@ -0,0 +1,27 @@
> +/* include/libc/string.h
> + *
> + * Copyright (C) 2007 David Cohen <da...@gm...>
> + * Copyright (C) 2007 Felipe Balbi <me...@fe...>
> + *
> + * This file is part of Tinyx Nanokernel Project.
> + *
> + * Tinyx is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 3 of the License, or
> + * (at your option) any later version.
> + *
> + * Tinyx is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with Tinyx.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef __TINYX_LIBC_STRING_H
> +#define __TINYX_LIBC_STRING_H
> +
> +int strcmp(const char *str1, const char *str2);
> +
> +#endif /* __TINYX_LIBC_STRING_H */
> diff --git a/include/tinyx/libc/string.h b/include/tinyx/libc/string.h
> deleted file mode 100644
> index 4ff2b08..0000000
> --- a/include/tinyx/libc/string.h
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/* include/tinyx/libc/string.h
> - *
> - * Copyright (C) 2007 David Cohen <da...@gm...>
> - * Copyright (C) 2007 Felipe Balbi <me...@fe...>
> - *
> - * This file is part of Tinyx Nanokernel Project.
> - *
> - * Tinyx is free software: you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation, either version 3 of the License, or
> - * (at your option) any later version.
> - *
> - * Tinyx is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with Tinyx.  If not, see <http://www.gnu.org/licenses/>.
> - */
> -
> -#ifndef __TINYX_LIBC_STRING_H
> -#define __TINYX_LIBC_STRING_H
> -
> -int strcmp(const char *str1, const char *str2);
> -
> -#endif /* __TINYX_LIBC_STRING_H */
> diff --git a/lib/libc/string.c b/lib/libc/string.c
> index 11c651b..d2e41a0 100644
> --- a/lib/libc/string.c
> +++ b/lib/libc/string.c
> @@ -19,7 +19,7 @@
>   * along with Tinyx.  If not, see <http://www.gnu.org/licenses/>.
>   */
>
> -#include <tinyx/libc/string.h>
> +#include <libc/string.h>
>
>  int strcmp(const char *str1, const char *str2)
>  {
> --
> 1.5.4.rc1.21.g0e545-dirty
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Tinyx-devel mailing list
> Tin...@li...
> https://lists.sourceforge.net/lists/listinfo/tinyx-devel
>



-- 
David Cohen
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil