Menu

#18 Crash due to illegal use of va_list

open
nobody
Bug: fatal (10)
5
2007-12-20
2007-12-20
No

/repeat -5 1 hi
/ps

TF 5.0b8.

Crash is due to use of va_list ap in vSprintf (tfio.c) after calling vsprintf() using the same variable. Calling v*printf macros leaves va_list in an undefined state; further use is illegal.

Patch attached.

Discussion

  • Lon Hohberger

    Lon Hohberger - 2007-12-20

    Makes a copy of the va_list before sending to vsprintf

     
  • Lon Hohberger

    Lon Hohberger - 2007-12-20

    Logged In: YES
    user_id=85411
    Originator: YES

    Note, I didn't look through the rest of the code to see if this was done elsewhere.

     

Log in to post a comment.