Menu

#197 fix string size handling in Unicode builds

None
closed
None
1
2016-07-04
2016-06-13
Giermann
No

Editing Notes is not possible anymore. Maybe it started with some Windows Update (Win7SP1 x64), but I traced it down to blame it on GetDlgItemText() in CEditDlgNoteText::OnChange().
It seemed to have some problems with too large requests...

Reading the code I found, that using sizeof() is unsuitable in Unicode builds without dividing through sizeof(TChar). I changed all occurences I found to the equivalent call with a CString instead of using temporaray fixed size buffers. Sometimes this was not suitable, where I fixed the use of sizeof() instead.

1 Attachments

Discussion

  • Don Lucas

    Don Lucas - 2016-07-04

    The attached patch has been successfully applied to version 2.90.00. This version will be released soon. Many thanks to user Giermann, and sorry for the delay.

     
  • Don Lucas

    Don Lucas - 2016-07-04
    • status: open --> closed
     

Log in to post a comment.