#6 Patch for task 130315, 130316 and 130317.

closed-accepted
5
2006-10-31
2006-10-30
karthik
No

Patch for task 130315, 130316 and 130317.

Discussion

  • Martijn Rutten

    Martijn Rutten - 2006-10-30
    • status: open --> pending
     
  • Martijn Rutten

    Martijn Rutten - 2006-10-30

    Logged In: YES
    user_id=1563356

    Reviewing...

     
  • Martijn Rutten

    Martijn Rutten - 2006-10-31

    Logged In: YES
    user_id=1563356

    Accepted the patch after major refactoring.

    TraceToolTipListener:
    - replaced drawing of label with canvas.setToolTip
    - factored out obtaining description string to separate SampleInfo subclasses
    - factored out setting the tooltip string to the TraceCanvas class
    - Replaced getSample call with SampleLine argument on the constructor
    - Replaced MouseTrackListener with MouseListener to ensure that tooltip is drawn
    immediately
    - Simplified getWidth()

    ZoomListener
    - Simplified getWidth()

    All canvases
    - removed getSample as this creates an unncessary external dependency

    MainViewer/SectionViewer/TraceLineViewer
    - removed pass listeners as a pointer to a collection, as only the
    cursorListener needs to be created at the MainViewer level (to be able to access the
    ruler area)
    - Created the zoom and tooltip listeners locally to avoid dependency from the
    MainViewer, SectionViewer, etc., and to allow to pass the sampleLine on the constructor.

    SampleLine
    - Reverted to previous version, change introduced a bug and did not add anything

     
  • Martijn Rutten

    Martijn Rutten - 2006-10-31
    • status: pending --> closed-accepted
     

Log in to post a comment.