#3 Revised patch for task 130318

closed-accepted
5
2006-09-15
2006-09-14
No

Incorporated review comments for the previous patch
(LabelsPatchVs0.3.diff)

Please, note that the patch has been generated after
updating with patch for story 5&7.

-Kishan

Discussion

  • Martijn Rutten

    Martijn Rutten - 2006-09-15
    • status: open --> pending
     
  • Martijn Rutten

    Martijn Rutten - 2006-09-15

    Logged In: YES
    user_id=1563356

    Reviewing the patch. Please update the original patch
    tracker item next time, instead of creating a new patch
    item.

     
  • Martijn Rutten

    Martijn Rutten - 2006-09-15

    Logged In: YES
    user_id=1563356

    Accepted the patch and included in the CVS repository with
    minor modifications:
    - changed the argument of CpuLabel from line to lineType.
    This way, the CpuLabel class has no dependency on the
    SampleLine class
    - Placed {} around if statement in TraceLineViewer to match
    with coding style
    - removed null check in setIcon as setIcon correctly
    handles null icons
    - renamed CpuLabel methods to better reflect the
    functionality

     
  • Martijn Rutten

    Martijn Rutten - 2006-09-15
    • status: pending --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks