#13 Extension point proposal

[Stuart Fullmer]

Provides Time Doctor extension points for defining your own events. Unzip the text file in the attached zip. Right click any of the plugins and select Team -> Apply Patch. Load this file as the patch and Eclipse should figure out the rest. I've tested this against a default TimeDocotr checkout.

[Stuart Fullmer]

Eclipse TEAM patch file

[Philippe Coucaud]

Logged In: YES
user_id=1706683
Originator: NO

Hi Stuart,

I just gave a look at your patch. I think it is too large to be integrated in one shot. Could you please try yo split it in separate and/or incremental pieces ? I've seen that you did some refactoring which I suspect could be integrated first in order to prepare the switch to the new extension point.

Another remark about ModelRGB. I totally agree with you that core.model should not depend on any UI classes (like swt.graphics.RGB which probably provide the same functionality as ModelRGB). I however think that it should be possible to use an adapter factory instead (in that case we just need to ensure that all classes from core.model having a color on screen extend PlatformObject or inherit IAdaptable, and methods like getMainColorTriple() would then be handled by the adapter factory). What do you think ? (as mentioned previously the patch is so large that I may have missed something ...)

For the EventDefinitions, maybe we could allow RGB components to be specified, instead of a class that implements ModelRGB (yes, I want to get ride of it :-) ? Or eventually some predefined symbolic name (eg: "red", "yellow") ...

[Nobody/Anonymous]

Logged In: NO

I need to reattach the patch as I've added new changes and merged code from the TD source back into our work. Unfortnueatly the code modifies so much it will be next to impossible to realistically break this into something smaller. The colors we're implemented as they are out of convenience, but I think a mnemonic/hex color addrsssing scheme would be much better than what si currently there. With Java, the mnemonics can map directly to the Color.NAMEs using the reflection API.