From: Benjamin M. <flo...@us...> - 2010-02-01 20:53:10
|
Regarding the new key mapping stuff: - Calculator key names are different from one model to another (TI-81's MODE is TI-83's STAT is TI-85's EXIT.) Do not hard-code the key names; use the names that are defined in the TilemHardware struct. - PC key names: surely there must be a better way than hard-coding these as well. Xlib and GDK have functions for mapping key names to and from keysym values; Qt must have something similar. - Looks like key sequences in the map file are backwards (MATH, ALPHA rather than ALPHA, MATH) ?! The key map file should be self-explanatory and easy to edit if somebody wants to do so. Benjamin |
From: Benjamin M. <flo...@us...> - 2010-02-01 22:58:53
|
>> - Calculator key names are different from one model to another >> (TI-81's MODE is TI-83's STAT is TI-85's EXIT.) Do not hard-code the >> key names; use the names that are defined in the TilemHardware struct. > > I'd love to but I have been unable to figure out a proper way to use it thus > far (I haven't tried very hard though...) I'll take another look at the code, but we should have already chosen the calculator model by the time we're loading the keymap, right? >> >> - PC key names: surely there must be a better way than hard-coding >> these as well. Xlib and GDK have functions for mapping key names to >> and from keysym values; Qt must have something similar. > > I'm sure it exists, the problem is that it may very well be internal. I'll > give it a look. > >> >> - Looks like key sequences in the map file are backwards (MATH, ALPHA >> rather than ALPHA, MATH) ?! > > I originally planned backward compatibility with TiEmu keymaps but it > doesn't turn out to be such a good idea after all. I see. I don't think compatibility there is a major concern - the 89's keypad layout is very different from the Z80 models' - and if compatibility means listing keys backwards, I'd be inclined to say forget about it. > As for the keymap "self-explanatoriness" if you have any idea to improve it > they are much welcome. I just meant that it would be clearer if we fixed the issues I mentioned above. :) Otherwise I think the format is fine. Benjamin |