Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[44057] branches/10.x

[lindon <li...@ti...>]

Jonny,
Agree this one is borderline or over the line of what a FIX is and you're
right, was doing it for a good cause - to help the release coordinator!
Understand of you'd rather I rolled it back.

By the way, it's not obvious to me how the Source field ever gets used - do
you know?
Thanks,
lindon


On Thu, Nov 22, 2012 at 7:31 AM, Jonny Bradley <svn...@no...>wrote:

>
> Cheeky Lindon!
>
> Adding a new parameter is not really a [FIX] - a fix mean mending
> something that's already in there but not working, not adding stuff to
> change the way something works, that's and [ENH] or a [MOD] imho.
>
> On the other hand, if it's for Bernard then i guess... ;)
>
> jb
>
>
>
> On 22 Nov 2012, at 03:08, li...@us... wrote:
>
> > Revision: 44057
> >
> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=44057&view=rev
> > Author:   lindonb
> > Date:     2012-11-22 03:08:22 +0000 (Thu, 22 Nov 2012)
> > Log Message:
> > -----------
> > [FIX] Reset property value to keep from carrying over to the next
> property if empty. Also add missing option to hide the source field (thanks
> bernard), although I don't know how this field ever gets used.
> >
> > Modified Paths:
> > --------------
> >    branches/10.x/lib/wiki-plugins/wikiplugin_files.php
> >    branches/10.x/templates/list_file_gallery_content.tpl
> >
> > Modified: branches/10.x/lib/wiki-plugins/wikiplugin_files.php
> > ===================================================================
> > --- branches/10.x/lib/wiki-plugins/wikiplugin_files.php       2012-11-21
> 22:30:22 UTC (rev 44056)
> > +++ branches/10.x/lib/wiki-plugins/wikiplugin_files.php       2012-11-22
> 03:08:22 UTC (rev 44057)
> > @@ -258,6 +258,19 @@
> >                                       array('text' => tra('No'), 'value'
> => 'n')
> >                               )
> >                       ),
> > +                     'showsource' => array(
> > +                             'required' => false,
> > +                             'name' => tra('Show Source'),
> > +                             'description' => tra('Show the source
> (shown by default).'),
> > +                             'filter' => 'alpha',
> > +                             'default' => 'n',
> > +                             'advanced' => true,
> > +                             'options' => array(
> > +                                     array('text' => '', 'value' => ''),
> > +                                     array('text' => tra('Yes'),
> 'value' => 'y'),
> > +                                     array('text' => tra('No'), 'value'
> => 'n')
> > +                             )
> > +                     ),
> >                       'slideshow' => array(
> >                               'required' => false,
> >                               'name' => tra('Show Slideshow'),
> > @@ -564,6 +577,7 @@
> >       if (!empty($showaction)) $gal_info['show_action'] = $showaction;
> >       if (!empty($showcomment)) $gal_info['show_comment'] = $showcomment;
> >       if (!empty($showlasteditor)) $gal_info['show_last_user'] =
> $showlasteditor;
> > +     if (!empty($showsource)) $gal_info['show_source'] = $showsource;
> >       if (!empty($showname) && $showname == 'y' && !empty($showfilename)
> && $showfilename == 'y') $gal_info['show_name'] = 'a';
> >       if (!empty($showname) && $showname == 'y' && !empty($showfilename)
> && $showfilename == 'n') $gal_info['show_name'] = 'n';
> >       if (!empty($showname) && $showname == 'n' && !empty($showfilename)
> && $showfilename == 'y') $gal_info['show_name'] = 'f';
> >
> > Modified: branches/10.x/templates/list_file_gallery_content.tpl
> > ===================================================================
> > --- branches/10.x/templates/list_file_gallery_content.tpl     2012-11-21
> 22:30:22 UTC (rev 44056)
> > +++ branches/10.x/templates/list_file_gallery_content.tpl     2012-11-22
> 03:08:22 UTC (rev 44057)
> > @@ -449,6 +449,7 @@
> >                                               {/if}
> >                                       {/if}
> >                               {/if}
> > +                             {$propval = null}
> >                       {/foreach}
> >
> >                       {if !empty($other_columns_selected_val)}
> >
> > This was sent by the SourceForge.net collaborative development platform,
> the world's largest Open Source development site.
> >
> >
> >
> ------------------------------------------------------------------------------
> > Monitor your physical, virtual and cloud infrastructure from a single
> > web console. Get in-depth insight into apps, servers, databases, vmware,
> > SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> > Pricing starts from $795 for 25 servers or applications!
> > http://p.sf.net/sfu/zoho_dev2dev_nov
> > _______________________________________________
> > Tikiwiki-cvs mailing list
> > Tik...@li...
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> >
>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>