Re: [Tiki-devel] Decoding HTML special characters in page sources

[Marc L. <ma...@ma...>]

Here are two example of what changes:
https://trunkdev.tiki.org/tiki-pagehistory.php?page=Online+Publishing+House+-+Collaborative+Editing&history_offset=1&diff_style=htmldiff&diff_style=sidediff&show_all_versions=y&compare=Compare&newver=0&oldver=3&paginate=on&history_pagesize=50

https://trunkdev.tiki.org/tiki-pagehistory.php?page=RoadMap&history_offset=1&diff_style=sidediff&diff_style=sidediff&show_all_versions=y&compare=Compare&newver=0&oldver=237&paginate=on&history_pagesize=50



On Sat, Dec 17, 2011 at 7:05 PM, Marc Laporte <ma...@ma...> wrote:
> Please take a 6.x and upgrade to trunk and check if all is well.
>
> Thanks!
>
> M ;-)
>
> On Sat, Dec 17, 2011 at 11:36 AM, geoff@enmore <ge...@en...> wrote:
>> Marc/Philippe - sorry but I need this spelling out a bit more. Describing
>> something as a one-way trip has clearly got my attention!!
>>
>> All my 6.xLTS production sites use WYSIWYG extensively.
>>
>> What exactly do I need to test? - in trunk presumably?? and what is the
>> impact when I upgrade from 6.xLTS to 9.xLTS when trunk becomes 9 next year
>>
>> Please advise
>>
>> Thanks
>>
>> Geoff
>>
>> ________________________________
>> From: Marc Laporte [mailto:ma...@ma...]
>> Sent: 17 December 2011 14:13
>> To: Tiki developers
>> Subject: Re: [Tiki-devel] Decoding HTML special characters in page sources
>>
>> Hi everyone!
>>
>> This is a major change. And this is a one-way trip.
>>
>> People using WYSIWYG should especially test
>>
>> Thanks!
>>
>> On 2011-12-15 10:07 PM, "Filipus Klutiero" <ch...@gm...> wrote:
>>>
>>> Le 2011-12-13 13:02, Philippe Cloutier a écrit :
>>> > Hi,
>>> > we have encoding problems with differences of wiki page versions. The
>>> > page
>>> > data in the database is stored escaped in tiki_pages and tiki_history.
>>> > That
>>> > causes the side by side diff function in wiki page edition preview to
>>> > show
>>> > untouched HTML special characters as modified. It also shows the
>>> > differences in versions double-encoded in page history.
>>> > It seems page content was stored that way since about forever. I changed
>>> > the storage format in trunk, but for existing installs a conversion is
>>> > needed.
>>> >
>>> > I made a script to do that this morning. The script must HTML decode
>>> > page
>>> > data, but only when data is Wiki syntax, not when it's HTML. I put a
>>> > check
>>> > for that, but I'm not sure that will work well in all cases (including
>>> > WYSIWYG). Code reviews and testing would be appreciated. Considering the
>>> > risk, I reverted my changes in
>>> > http://sourceforge.net/apps/trac/tikiwiki/changeset/39171
>>> > If you can, please locally revert 39171 (which will restore my changes)
>>> > and
>>> > test.
>>> >
>>> > While HTML encoding then HTML decoding is idempotent, HTML decoding then
>>> > HTML encoding is not. The conversion script intends to decode HTML
>>> > encoded
>>> > data, but if it decodes data which is not HTML encoded, it could
>>> > slightly
>>> > corrupt data (HTML encoding the result won't necessarily restore the
>>> > original situation). The script archives the previous version of pages
>>> > if
>>> > history is enabled, but previous versions could be lost if history is
>>> > disabled.
>>> >
>>> > I intend to revert r39171 in the next days if no one finds problems in
>>> > it.
>>> >
>>> > Thanks
>>> >
>>> I did that in r39206.
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Learn Windows Azure Live!  Tuesday, Dec 13, 2011
>>> Microsoft is holding a special Learn Windows Azure training event for
>>> developers. It will provide a great way to learn Windows Azure and what it
>>> provides. You can attend the event by watching it streamed LIVE online.
>>> Learn more at http://p.sf.net/sfu/ms-windowsazure
>>> _______________________________________________
>>> TikiWiki-devel mailing list
>>> Tik...@li...
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>> ________________________________
>>
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2012.0.1890 / Virus Database: 2108/4685 - Release Date: 12/16/11
>>
>> ________________________________
>>
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2012.0.1890 / Virus Database: 2108/4685 - Release Date: 12/16/11
>>
>>
>> ------------------------------------------------------------------------------
>> Learn Windows Azure Live!  Tuesday, Dec 13, 2011
>> Microsoft is holding a special Learn Windows Azure training event for
>> developers. It will provide a great way to learn Windows Azure and what it
>> provides. You can attend the event by watching it streamed LIVE online.
>> Learn more at http://p.sf.net/sfu/ms-windowsazure
>> _______________________________________________
>> TikiWiki-devel mailing list
>> Tik...@li...
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
>
>
> --
> Marc Laporte
>
> http://MarcLaporte.com
> http://Tiki.org/MarcLaporte
> http://AvanTech.net



-- 
Marc Laporte

http://MarcLaporte.com
http://Tiki.org/MarcLaporte
http://AvanTech.net