From: Filipus K. <ch...@gm...> - 2011-08-23 19:31:32
|
OK. FWIW, the first one wouldn't match your regex, but I agree about the second. At the same time, I think it would be cleaner if everything used %0, but that must be a too large change. Le 2011-08-23 15:03, Jean-François BILGER a écrit : > No, you can find > "{if \$prefs.menus_item_names_raw eq 'n'}{\$chdata.name > <http://chdata.name>|escape}{else}{\$chdata.name > <http://chdata.name>}{/if}" => "{if \$prefs.menus_item_names_raw eq > 'n'}{\$chdata.name <http://chdata.name>|escape}{else}{\$chdata.name > <http://chdata.name>}{/if}", > "{\$wp_member_title}" => "{\$wp_member_title}", > > But i really think they must be ignored, because they can/must not be > translated. > > Changi > > 2011/8/23 Filipus Klutiero <ch...@gm... <mailto:ch...@gm...>> > > Oh, right. Is this something the current get_strings does? > > Le 2011-08-22 14:34, Jean-François BILGER a écrit : >> But they are not invalid string, they are used to translate >> variable like category or tags. >> >> 2011/8/22 Rodrigo Primo <rod...@gm... >> <mailto:rod...@gm...>> >> >> Hi, >> >> I agree with Chealer. I prefer to warn the users of the >> invalid strings instead of ignoring them when get_strings.php >> is run. After all from get_strings.php point of view they are >> valid. The problem is that they should not be declared in the >> template files. >> >> I'm not sure if I will have time to do this. But a cleanup of >> templates is necessary. >> >> Rodrigo >> >> On Fri, Aug 19, 2011 at 7:19 PM, Filipus Klutiero >> <ch...@gm... <mailto:ch...@gm...>> wrote: >> >> Perhaps warn whoever runs get_strings they exist so the >> templates can be cleaned. >> >> Le 2011-08-19 16:17, Jean-François BILGER a écrit : >>> Another thing, >>> >>> Maybe we should exclude all translation like #^{\$.*}$# >>> >>> Changi >>> >>> 2011/8/19 Jean-François BILGER <cha...@gm... >>> <mailto:cha...@gm...>> >>> >>> Nice work >>> >>> Some remarks >>> >>> 2011/8/19 Rodrigo Primo <rod...@gm... >>> <mailto:rod...@gm...>> >>> >>> Hi, >>> >>> I have created a new get_strings.php script. For >>> now it is called get_strings2.php and if >>> everything is working good it will replace the >>> old script. >>> >>> Please help testing the new script and report >>> bugs and suggestions. See the header of the file >>> for a list of accepted parameters. Let me know >>> if you miss any option available in the old >>> script that I didn't implemented in the new one. >>> >>> There are only two differences visible to the >>> translators: >>> >>> 1) The new get_strings.php doesn't keep in >>> language.php files unused strings as the old one >>> does. >>> >>> >>> Sometimes we need unused work when some are passed >>> as param >>> >>> 2) language.php files are not divided anymore in >>> translated, untranslated and unused sections. >>> The strings are ordered as they appear in the >>> source files independently if they have been >>> translated or not. >>> >>> >>> The main motivation to rewrote the script was to >>> make it easier to maintain and extend the code >>> in the future. >>> >>> In the process I fixed some old bugs. Like >>> https://dev.tiki.org/tiki-view_tracker_item.php?itemId=3881 >>> and >>> https://dev.tiki.org/tiki-view_tracker_item.php?itemId=3975 >>> (the bugs were fixed both in the old and new >>> get_strings.php). >>> >>> If there are no objections or bugs I'm planning >>> to replace the old get_strings.php with the new >>> script by the end of the next week. >>> >>> >>> What about the cli param like >>> >>> get_strings.php lang=onlyonelanguage >>> >>> What about completion param? >>> >>> Maybe we could copy/paste the cli param from the >>> actual ? >>> >>> I think we should wait a little more to switch. >>> >>> My 2c. >>> >>> >>> >>> Cheers, Rodrigo. >>> >>> -- >>> http://rodrigo.utopia.org.br >>> >>> >>> >> >> > > |