From: Sylvie G. <sgr...@gm...> - 2010-06-09 15:07:29
|
We have to rewrite this - I also spend too much time each time I want to fix something - /me hates duplication another bug on my list On Wed, 2010-06-09 at 15:52 +0100, Jonny Bradley wrote: > Oooer, thanks Sylvie - good catch, i'll roll it back. > > The trouble is that non-admin users can't actually edit (or even see) fields that are supposed to be editable by creator... so it seems to be a useless option. Any idea how to fix it properly? (without rewriting practically the whole thing - it's such a mess, as you know. I got lost and panicked!) > > jb > > > On 9 Jun 2010, at 15:34, Sylvie Greverend wrote: > > > It is very dangerous to play with createdBy. > > They do not have the same behavior - Kerrnel added it but it is not > > consistent with the user field > > For instance an admin can create an item with an another creator name - > > but he can not change createdBy > > The visibilty needs a field user creator -as it is said in the doc -so > > if you want to test createdby you need also to test that there is no > > user creator field too - because otehrwise it will be inconsistent > > My 2 cents > > > > The creator id the one in the user field not the one in createdBy > > For isntance , if an admin wants to change the creator of an item - he > > can do it > > On Wed, 2010-06-09 at 14:27 +0000, jon...@us... > > wrote: > >> Revision: 27569 > >> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=27569&view=rev > >> Author: jonnybradley > >> Date: 2010-06-09 14:27:06 +0000 (Wed, 09 Jun 2010) > >> > >> Log Message: > >> ----------- > >> [FIX] Tracker "creator can edit" fields: Sometimes (e.g. tiki-view_tracker_item.php) it uses item.createdBy not item.creator > >> > >> Modified Paths: > >> -------------- > >> trunk/templates/tracker_item_field_input.tpl > >> > >> Modified: trunk/templates/tracker_item_field_input.tpl > >> =================================================================== > >> --- trunk/templates/tracker_item_field_input.tpl 2010-06-09 13:51:11 UTC (rev 27568) > >> +++ trunk/templates/tracker_item_field_input.tpl 2010-06-09 14:27:06 UTC (rev 27569) > >> @@ -9,7 +9,7 @@ > >> {if $field_value.isHidden eq 'y' and $tiki_p_admin_trackers ne 'y'} > >> > >> {* ---- visible by admin and creator --- *} > >> -{elseif $field_value.isHidden eq 'c' and $tiki_p_admin_trackers ne 'y' and isset($item) and $user ne $item.creator} > >> +{elseif $field_value.isHidden eq 'c' and $tiki_p_admin_trackers ne 'y' and isset($item) and $user ne $item.creator and $user ne $item.createdBy} > >> > >> {* ---- editable admin only ---- *} > >> {elseif $field_value.isHidden eq 'p' and $tiki_p_admin_trackers ne 'y'} > >> > >> > >> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > >> > >> ------------------------------------------------------------------------------ > >> ThinkGeek and WIRED's GeekDad team up for the Ultimate > >> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > >> lucky parental unit. See the prize list and enter to win: > >> http://p.sf.net/sfu/thinkgeek-promo > >> _______________________________________________ > >> Tikiwiki-cvs mailing list > >> Tik...@li... > >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > > > > > > ------------------------------------------------------------------------------ > > ThinkGeek and WIRED's GeekDad team up for the Ultimate > > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > > lucky parental unit. See the prize list and enter to win: > > http://p.sf.net/sfu/thinkgeek-promo > > _______________________________________________ > > Tikiwiki-cvs mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > |