From: Jonny B. <jo...@ti...> - 2010-03-16 12:44:03
|
Hi Gary - i refactored the body tag code (it was duplicated all over the place - nasty mess!) but i don't think i lost anything on the way... What was lost when i refactored it? I don't see anything regarding the page name as id here: http://tikiwiki.svn.sourceforge.net/viewvc/tikiwiki/trunk/templates/tiki.tpl?r1=25159&r2=25158&pathrev=25159 It would be fairly simple to add now though... in the smarty object of course! ;) The redundant class tiki and pointless prefix tiki_ were fought hard for a while ago, but i agree they are totally unnecessary but i'm not that bovvered... I'm not sure i completely agree about the wiki_page vs "wiki page" - what else would you have - wiki and what? And where else would you use the class "page" separately? There are slight issues all over the place due to varieties in 'wiki page' 'wiki' 'wiki_page' etc - something to fix for 6? jb On 16 Mar 2010, at 10:26, Gary Cunningham-Lee wrote: > Hi, > > In branch 5x, the body tag (still - also true in 4.x and trunk) looks > like <body class="tiki tiki_wiki_page">. Is there a reason for this > redundancy? There was discussion several months ago but the problem > wasn't resolved. I don't see a purpose for the "tiki" or "tiki_" class > at all. What is its scope - every page Tiki serves? Since presumably the > Tiki CSS files aren't used for pages other than in Tiki, the class is > pointless, I think. The same purpose can be achieved by just applying a > CSS rule globally. > > Then, about "wiki_page", I think having "wiki page" would be more > useful, with one class for the section and one for the type of content. > In fact, I believe this was the case earlier, but somehow the two > classes mistakenly got combined into one. > > Currently even pages like tiki-listpages.php have the class > "tiki_wiki_page" so they isn't distinguished from a wiki page proper, > which seems wrong; tiki-listpages.php does also have a "manage" class, > which makes sense, so "wiki manage" seems correct here - one class for > the wiki section and the "manage" class for the function (to distinguish > from wiki content pages). > > Also, I committed a tiki.tpl edit to give each wiki page an id in the > body tag, based on pageId, so CSS could be page-specific. (I know lines > of code can be added in Look & Feel to filter this, but I believe having > the id added automatically would help keep L&F less cluttered, keep CSS > more efficient, and so on.) I wonder what happened to that? Seems like > it got lost when the body tag contents were moved out of the template. > > -- Gary > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |