From: Jonny B. <jo...@ti...> - 2010-02-09 19:37:10
|
This was broken by a multi-replace commit (r22634 last October) and obviously hasn't been tested - it caused parsing from html to wiki to fail when there was a <ul>/<li> in the page. These little changes need careful checking... I'm checking the other ones and have found one in lib/Date/Calc.php which looks like it's a duplicate of the PEAR Date/Calc.php and isn't used - can anyone confirm (or remember why this dir is there?) I'm guessing it can be KIL'ed? jb On 9 Feb 2010, at 19:25, jon...@us... wrote: > Revision: 25002 > http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=25002&view=rev > Author: jonnybradley > Date: 2010-02-09 19:25:57 +0000 (Tue, 09 Feb 2010) > > Log Message: > ----------- > [FIX] Move strlen function back to 2nd arg of enigmatic "for" loop (partial rollback of r22634 which caused an endless loop here) > N.B. Also needs back-porting to 4.x > > Modified Paths: > -------------- > trunk/lib/wiki/editlib.php > > Modified: trunk/lib/wiki/editlib.php > =================================================================== > --- trunk/lib/wiki/editlib.php 2010-02-09 18:59:39 UTC (rev 25001) > +++ trunk/lib/wiki/editlib.php 2010-02-09 19:25:57 UTC (rev 25002) > @@ -326,7 +326,7 @@ > // Generate wiki list item according to current list depth. > // (ensure '*/#' starts from begining of line) > $temp_max = count($p['listack']); > - for ($l = '', $strl_l = strlen($l); $strl_l < $temp_max; $l .= end($p['listack'])); > + for ($l = ''; strlen($l) < $temp_max; $l .= end($p['listack'])); // needs strlen function in 2nd for loop argument > $src .= "\n$l "; > break; > case "font": > > > This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > > ------------------------------------------------------------------------------ > SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, > Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW > http://p.sf.net/sfu/solaris-dev2dev > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |