From: Sylvie G. <sgr...@gm...> - 2009-12-04 16:31:30
|
Thanks btw I got 5 syntax errors to display the newsletter pages this morning in trunk.... Painful On Fri, 2009-12-04 at 16:44 +0100, WEBER Patrice wrote: > Hi Sylvie, > > Hmmm... you added $mid inside the query... And it was already in $mid2 > when not empty... You will have it twice ... > > Cheers, > Nyloth > > -----Original Message----- > From: sy...@us... > [mailto:sy...@us...] > Sent: Friday 4 December 2009 16:25 > To: tik...@li... > Subject: [Tikiwiki-cvs/svn] SF.net SVN: > tikiwiki:[23666]trunk/lib/newsletters/nllib.php > > Revision: 23666 > > http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=23666&view=rev > Author: sylvieg > Date: 2009-12-04 15:25:06 +0000 (Fri, 04 Dec 2009) > > Log Message: > ----------- > [FIX]newsletter: incorrect syntax > > Modified Paths: > -------------- > trunk/lib/newsletters/nllib.php > > Modified: trunk/lib/newsletters/nllib.php > =================================================================== > --- trunk/lib/newsletters/nllib.php 2009-12-04 15:20:45 UTC (rev > 23665) > +++ trunk/lib/newsletters/nllib.php 2009-12-04 15:25:06 UTC (rev > 23666) > @@ -498,11 +498,11 @@ > $bindvars[] = $findesc; > $bindvars[] = $findesc; > } else { > - $mid = " "; > + $mid = ''; > } > > $mid2 = ( empty( $mid ) ? ' WHERE ' : $mid . ' AND ' ) . > ' tn.`nlId` = tsn.`nlId`'; > - $query = "select tn.*, max(tsn.`sent`) as lastSent from > `tiki_newsletters` as tn, `tiki_sent_newsletters` as tsn $mid2 group by > tn.`nlId` order by ".$this->convertSortmode("$sort_mode"); > + $query = "select tn.*, max(tsn.`sent`) as lastSent from > `tiki_newsletters` as tn, `tiki_sent_newsletters` as tsn $mid $mid2 > group by tn.`nlId` order by ".$this->convertSortmode("$sort_mode"); > $result = > $this->query($query,$bindvars,$maxRecords,$offset); > $query_cant = "select count(*) from `tiki_newsletters` > as tn $mid"; > $cant = $this->getOne($query_cant,$bindvars); > > > This was sent by the SourceForge.net collaborative development platform, > the world's largest Open Source development site. > > ------------------------------------------------------------------------ > ------ > Join us December 9, 2009 for the Red Hat Virtual Experience, > a free event focused on virtualization and cloud computing. > Attend in-depth sessions from your desk. Your couch. Anywhere. > http://p.sf.net/sfu/redhat-sfdev2dev > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > ------------------------------------------------------------------------------ > Join us December 9, 2009 for the Red Hat Virtual Experience, > a free event focused on virtualization and cloud computing. > Attend in-depth sessions from your desk. Your couch. Anywhere. > http://p.sf.net/sfu/redhat-sfdev2dev > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |