[Tikiwiki-devel] smartypdt plugin for Eclipse

[Jonny B <jm...@no...>]

Hi again

I've just got smartypdt working (v 0.5.5 - see notes on
http://doc.tikiwiki.org/Developing+TikiWiki+with+Eclipse+on+a+Mac#_Get_smart
ypdt_Smarty_Support_for_PDT_)

...and it's throwing up a _huge_ amount of errors (298) and warning
(23,746!). Some of these i have ruled out as parsing errors on nested {if}s
(it's bug i think) and tags opened in other templates (i wonder if there's
any Smarty way of annotating that) but many of them seem real - here are a
few examples...

(</form>) not closed. tiki-admin_menu_options.tpl    line 302
(</td>) not closed.   tiki-calendar_edit_item.tpl    line 217
No start tag (<a>).   browse_file_gallery.tpl        line 133
No start tag (<a>).   tiki-approve_staging_page.tpl  line 1

My question is, can we trust these error messages (probably not entirely
yet) and should i start committing fixes? I'll do some experiments to check
if it improves validation and and get back to you but i would appreciate
feedback from more experienced Tiki-devs.

It also does a pretty good job of formatting .tpl files, which makes
spotting errors so much easier - but that seems to be a touchy subject
sometimes, what do people think - maybe could be something for the next bug
fixing day?

jonny